Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the empty binding for allowed environment type upgrades in k8s infrastructure #13466

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Initialize the empty binding for allowed environment type upgrades in k8s infrastructure #13466

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2927747
Initialize the empty binding for allowed environment type upgrades in
metlos Jun 3, 2019
339db91
Add an explanatory comment for how we initialize the environment upgrade
metlos Jun 3, 2019
bb76592
Fix a typo in the comment
amisevsk Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/KubernetesInfraModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,5 +205,10 @@ protected void configure() {
binder(), KubernetesEnvironment.TYPE);
KubernetesDevfileBindings.addKubernetesBasedComponentTypeBindings(
binder(), KUBERNETES_COMPONENT_TYPE);

// We need to initialize the bindings somehow. Because no other environment type is upgradable
// to kubernetes, we just call this in a way that initializes the binding with an empty map.
KubernetesDevfileBindings.addAllowedEnvironmentTypeUpgradeBindings(
binder(), KubernetesEnvironment.TYPE);
}
}