K8s-like devfile naming #13490
Merged
K8s-like devfile naming #13490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are not passing. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
metlos
requested review from
ashumilova,
benoitf,
mshaposhnik,
skabashnyuk,
sleshchenko and
vparfonov
as code owners
…naming Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
mshaposhnik
reviewed
Jun 7, 2019
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
ci-build |
sleshchenko
reviewed
Jun 10, 2019
...e-core-api-model/src/main/java/org/eclipse/che/api/core/model/workspace/devfile/Devfile.java
Outdated
Show resolved
Hide resolved
...e-core-api-model/src/main/java/org/eclipse/che/api/core/model/workspace/devfile/Devfile.java
Outdated
Show resolved
Hide resolved
...ace/src/main/java/org/eclipse/che/api/workspace/server/devfile/convert/DevfileConverter.java
Outdated
Show resolved
Hide resolved
...pace/src/main/java/org/eclipse/che/api/workspace/server/model/impl/devfile/MetadataImpl.java
Outdated
Show resolved
Hide resolved
...space/src/main/java/org/eclipse/che/api/workspace/server/model/impl/devfile/DevfileImpl.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
Jun 10, 2019
.../java/org/eclipse/che/api/workspace/server/devfile/validator/DevfileSchemaValidatorTest.java
Show resolved
Hide resolved
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
to the latest API version. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
tests. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
…naming Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
sleshchenko
approved these changes
Jun 10, 2019
|
ci-test |
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
…naming Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
4 tasks
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
`specVersion` is now `apiVersion` and is bumped to 1.0.0 `name` is now nested under the new `metadata` element. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
skabashnyuk
pushed a commit
to skabashnyuk/che
that referenced
this pull request
Mar 11, 2020
`specVersion` is now `apiVersion` and is bumped to 1.0.0 `name` is now nested under the new `metadata` element. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This renames
specVersiontoapiVersionandnametometadata.nameso that devfile is more in line with kubernetes conventions.What issues does this PR fix or reference?
#13336