Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-13476 improve CHE-6 workspaces warning #13506

Merged
merged 2 commits into from
Jul 31, 2019
Merged

CHE-13476 improve CHE-6 workspaces warning #13506

merged 2 commits into from
Jul 31, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 10, 2019 •
edited
Loading

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Improve CHE-6 workspaces warning. Add a link in the pop-up warning message to the documentation, change font icon.

What issues does this PR fix or reference?

#13476

Release Notes

Docs PR

https://docs.google.com/document/d/1qrHg4F2FvTpafJAvgqgzeYTu6M0UA1mSjm_UCoQNFHc/edit?usp=sharing

Screenshot from 2019-06-10 19-06-04
https://youtu.be/2g9sdXLZQF8

@olexii4 olexii4 requested a review from benoitf as a code owner June 10, 2019 16:08
@olexii4
Copy link
Contributor Author

olexii4 commented Jun 11, 2019

@slemeur WDYT?

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 12, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 12, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 12, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 12, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4 olexii4 force-pushed the CHE-13476 branch 2 times, most recently from 9627d95 to 5cf31fe Compare June 18, 2019 09:06
@olexii4
Copy link
Contributor Author

olexii4 commented Jun 18, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 18, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 19, 2019

ci-test

@olexii4 olexii4 requested a review from artaleks9 June 19, 2019 07:25
@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1869//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@olexii4 olexii4 requested review from SkorikSergey and removed request for artaleks9 June 19, 2019 13:50
@slemeur
Copy link
Contributor

slemeur commented Jun 20, 2019

@olexii4 What documentation it is pointing to?

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 20, 2019 •
edited
Loading

@slemeur I have added the link(in the description)

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/question Questions that haven't been identified as being feature requests or bugs. labels Jun 27, 2019
@olexii4 olexii4 requested a review from evidolob July 1, 2019 13:52
@olexii4 olexii4 mentioned this pull request Jul 5, 2019
Closed
6 tasks
@ashumilova
Copy link
Contributor

Current state: waiting for the appropriate documentation to be merged.

@evidolob evidolob mentioned this pull request Jul 24, 2019
Closed
18 tasks
l0rd
l0rd reviewed Jul 30, 2019
View reviewed changes
dashboard/src/app/workspaces/list-workspaces/workspace-item/workspace-item.controller.ts Outdated
this.supportedRecipeTypeIssue = $sce.trustAsHtml('Current infrastructure doesn\'t support this workspace recipe type.');

this.supportedVersionTypeIssue = $sce.trustAsHtml(`This workspace is using old definition format which is not compatible anymore.
Please follow the <a href="${cheBranding.getDocs().workspace}" target="_blank">documentation</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to reference the link to the doc section "Converting a Che 6 Workspace to a Che 7 devfile" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is possible. I have changed reference the link to the doc section "Converting a Che 6 Workspace to a Che 7 devfile"
2e2c2cc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@olexii4
CHE-13476 improve CHE-6 workspaces warning
538905e 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Fix a link
af89848 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@l0rd
Copy link
Contributor

l0rd commented Jul 31, 2019

Not in the endgame but necessary to deploy Che 7 on che.osio. I am +1 to merge to master.

@olexii4
Copy link
Contributor Author

olexii4 commented Jul 31, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 31, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1967/) doesn't show any regression against this Pull Request.

@olexii4 olexii4 merged commit d621466 into master Jul 31, 2019
@olexii4 olexii4 deleted the CHE-13476 branch July 31, 2019 14:30
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 31, 2019
@evidolob evidolob mentioned this pull request Aug 7, 2019
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@ashumilova ashumilova ashumilova approved these changes

@l0rd l0rd l0rd approved these changes

@benoitf benoitf benoitf approved these changes

@slemeur slemeur Awaiting requested review from slemeur

@evidolob evidolob Awaiting requested review from evidolob

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@olexii4 @che-bot @SkorikSergey @slemeur @ashumilova @l0rd @artaleks9 @benoitf @akurinnoy