Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of error status of a workspace #13535

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes bug when workspace-loader is not able to handle an error status which is set immediately after workspace has been started.

What issues does this PR fix or reference?

fix #13209

@akurinnoy akurinnoy added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 13, 2019
@akurinnoy akurinnoy self-assigned this Jun 13, 2019
@akurinnoy
Copy link
Contributor Author

akurinnoy commented Jun 13, 2019

depends on #13532 merged

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy marked this pull request as ready for review June 21, 2019 07:39
@akurinnoy
Copy link
Contributor Author

ci-build

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 27, 2019
@akurinnoy akurinnoy merged commit edfda13 into eclipse-che:master Jul 2, 2019
@akurinnoy akurinnoy deleted the handle-fail-after-start branch July 2, 2019 13:47
@akurinnoy akurinnoy restored the handle-fail-after-start branch July 4, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspace-loader doesn't recognize when workspace start fails immediately after start request is sent
4 participants