Remove GWT-related code from Java selenium E2E tests #13829

dmytro-ndp · 2019-07-12T10:19:45Z

What does this PR do?

Decouple Java selenium E2E tests from GWT-code:

Removes dependencies on plugins artifacts:
- org.eclipse.che.plugin:che-plugin-github-shared
- org.eclipse.che.plugin:che-plugin-github-server
- org.eclipse.che.core:che-core-api-debug-shared
Removes tests which aimed to verify GWT-editor functionality:
- org.eclipse.che.selenium.assistant.*
- org.eclipse.che.selenium.languageserver.*
- org.eclipse.che.selenium.debugger.*
- org.eclipse.che.selenium.editor.*
- org.eclipse.che.selenium.filewatcher.*
- org.eclipse.che.selenium.git.*
- org.eclipse.che.selenium.intelligencecommand.*
- org.eclipse.che.selenium.mavenplugin.*
- org.eclipse.che.selenium.miscellaneous.*
- org.eclipse.che.selenium.opendeclaration.*
- org.eclipse.che.selenium.plainjava.*
- org.eclipse.che.selenium.testrunner.*
- org.eclipse.che.selenium.projectexplorer.*
- org.eclipse.che.selenium.refactor.*
- org.eclipse.che.selenium.stack.*
- org.eclipse.che.selenium.workspaces.CheckStopStartWsTest
Moves GitHubKey class to test project
Works around e2e tests which use che6 workspaces to check functionality which doesn't related to GWT-stuff, and so should be rewritten to use che7 ones:
- org.eclipse.che.selenium.workspaces.CheckStoppingWsByTimeoutTest
- org.eclipse.che.selenium.workspaces.CreateWorkspaceOnDashboardTest
- org.eclipse.che.selenium.workspaces.ProjectStateAfterRefreshTest
- org.eclipse.che.selenium.workspaces.ProjectStateAfterWorkspaceRestartTest
- org.eclipse.che.selenium.site.ocpoauth.LoginExistedUserWithOpenShiftOAuthTest
- org.eclipse.che.selenium.site.ocpoauth.LoginNewUserWithOpenShiftOAuthTest
- org.eclipse.che.selenium.dashboard.organization.ShareWorkspaceMemberTest
- org.eclipse.che.selenium.dashboard.workspaces.AddOrImportProjectFormTest
- org.eclipse.che.selenium.dashboard.ImportProjectFromGitHubTest
- org.eclipse.che.selenium.swagger.SwaggerTest
- org.eclipse.che.selenium.hotupdate.*
- org.eclipse.che.selenium.factory.DirectUrlFactoryWithKeepDirectoryTest
- org.eclipse.che.selenium.factory.DirectUrlFactoryWithRootFolderTest
- org.eclipse.che.selenium.factory.DirectUrlFactoryWithSpecificBranchTest
Removes classes of tests which had been removed from test suites previously.

What issues does this PR fix or reference?

#13827, #13788

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

benoitf · 2019-07-12T10:35:49Z

it that this PR should go in @skabashnyuk branch ? instead of master

dmytro-ndp · 2019-07-12T11:29:33Z

it would be grateful, if it's possible.
I am going to merge further changes from upstream branch che7cleanup to make it possible.

…d missed artifact from mvn central Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

…lenium

…d missed artifact from mvn central Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

…lenium

…d missed artifact from mvn central Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

…lenium

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-16T11:56:22Z

ci-test

che-bot · 2019-07-16T12:44:05Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-16T13:06:56Z

ci-test

che-bot · 2019-07-16T13:49:11Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-17T07:27:30Z

ci-test

che-bot · 2019-07-17T08:14:35Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-17T10:27:37Z

ci-test

che-bot · 2019-07-17T11:12:38Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-17T13:27:24Z

ci-test

che-bot · 2019-07-17T14:12:44Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-17T15:18:03Z

ci-test

che-bot · 2019-07-17T16:02:51Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

…iously Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-17T17:45:38Z

ci-test

che-bot · 2019-07-17T18:32:45Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2019-07-17T21:03:42Z

ci-test

che-bot · 2019-07-17T22:26:30Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-07-18T16:09:25Z

ci-build

dmytro-ndp · 2019-07-18T16:10:18Z

ci-test

che-bot · 2019-07-18T16:59:03Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13829
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

musienko-maxim · 2019-07-18T18:03:59Z

Your build is failure

dmytro-ndp · 2019-07-19T09:50:29Z

@skabashnyuk, @vparfonov: Java selenium e2e tests had been fixed to be run against Che 7 without GWT-code.
If you don't mind, I will merge changes from this PR into upstream branch #13788

cleanup of che6 legacy code Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com> * Remove/disable GWT-related code in Java selenium E2E tests (#13829) Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Build java selenium tests

03b2169

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp changed the base branch from master to che7cleanup July 12, 2019 11:30

dmytro-ndp added 7 commits July 12, 2019 15:18

Move to temporary version 7.0.0-rc-4.1-SNAPSHOT to prevent mvn to loa…

9bcd88e

…d missed artifact from mvn central Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Merge remote-tracking branch 'origin/che7cleanup' into che7cleanup-se…

8700ddb

…lenium

Move to temporary version 7.0.0-rc-4.1-SNAPSHOT to prevent mvn to loa…

f087401

…d missed artifact from mvn central Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Merge remote-tracking branch 'origin/che7cleanup' into che7cleanup-se…

20df207

…lenium

Move to temporary version 7.0.0-rc-4.1-SNAPSHOT to prevent mvn to loa…

4921c0d

…d missed artifact from mvn central Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Merge remote-tracking branch 'origin/che7cleanup' into che7cleanup-se…

15d06e1

…lenium

Remove Java selenium e2e tests of GWT-editor

8aa9823

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Temporary include flacky tests and test under repair

d00eb08

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Remove stacks related Java selenium e2e tests

76fe694

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp added 3 commits July 17, 2019 12:31

Don't use che6 workspace in SwaggerTest

384739a

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Don't fail e2e tests if factory object is null

9f211db

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Disable outdated e2e tests

96af445

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Work around execption when delete test factory

83e16a8

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Restore 7.0.0-rc-4.0-SNAPSHOT version

6c3e8bd

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp marked this pull request as ready for review July 17, 2019 16:17

dmytro-ndp requested review from l0rd, musienko-maxim, nickboldt, Ohrimenko1988, rhopp and vparfonov as code owners July 17, 2019 16:17

dmytro-ndp added 2 commits July 17, 2019 20:29

Remove outdated e2e tests for docker assembly

b47ba81

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Removes classes of tests which had been removed from test suites prev…

052e457

…iously Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Restored the tests which could be useful for che7

0809eb4

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

skabashnyuk approved these changes Jul 19, 2019

View reviewed changes

dmytro-ndp merged commit 41b5fb4 into che7cleanup Jul 19, 2019

dmytro-ndp deleted the che7cleanup-selenium branch July 19, 2019 12:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove GWT-related code from Java selenium E2E tests #13829

Remove GWT-related code from Java selenium E2E tests #13829

dmytro-ndp commented Jul 12, 2019 •

edited

Loading

benoitf commented Jul 12, 2019 •

edited

Loading

dmytro-ndp commented Jul 12, 2019

dmytro-ndp commented Jul 16, 2019

che-bot commented Jul 16, 2019

dmytro-ndp commented Jul 16, 2019

che-bot commented Jul 16, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 18, 2019

dmytro-ndp commented Jul 18, 2019

che-bot commented Jul 18, 2019

musienko-maxim commented Jul 18, 2019

dmytro-ndp commented Jul 19, 2019 •

edited

Loading

Remove GWT-related code from Java selenium E2E tests #13829

Remove GWT-related code from Java selenium E2E tests #13829

Conversation

dmytro-ndp commented Jul 12, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

benoitf commented Jul 12, 2019 • edited Loading

dmytro-ndp commented Jul 12, 2019

dmytro-ndp commented Jul 16, 2019

che-bot commented Jul 16, 2019

dmytro-ndp commented Jul 16, 2019

che-bot commented Jul 16, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 17, 2019

che-bot commented Jul 17, 2019

dmytro-ndp commented Jul 18, 2019

dmytro-ndp commented Jul 18, 2019

che-bot commented Jul 18, 2019

musienko-maxim commented Jul 18, 2019

dmytro-ndp commented Jul 19, 2019 • edited Loading

dmytro-ndp commented Jul 12, 2019 •

edited

Loading

benoitf commented Jul 12, 2019 •

edited

Loading

dmytro-ndp commented Jul 19, 2019 •

edited

Loading