Adapt Stacks in UD to Che 7 #13833

olexii4 · 2019-07-12T12:33:11Z

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Adapt Stacks in UD to Che 7.

What issues does this PR fix or reference?

#13811

https://youtu.be/OYP1QzlbNjA

slemeur · 2019-07-12T13:27:45Z

Can we display the devfile in another page? because here it seems confusing IMO

…

On Fri, Jul 12, 2019 at 2:33 PM Oleksii Orel ***@***.***> wrote: @olexii4 <https://github.com/olexii4> requested your review on: #13833 <#13833> Adapt Stacks in UD to Che 7. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#13833>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMPTIKZTFGVIDI6636LTHLP7B2YTANCNFSM4ICI32RQ> .

-- Stévan LeMeur // Product Manager // Developer Tools // +336-87-11-27-55

olexii4 · 2019-07-15T07:48:58Z

ci-test

che-bot · 2019-07-15T11:02:04Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13833
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2019-07-18T11:24:22Z

@slemeur I have updated
https://youtu.be/Rp5S_FX9Kbs

olexii4 · 2019-07-18T11:25:14Z

ci-test

che-bot · 2019-07-18T11:51:29Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13833
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

akurinnoy · 2019-07-18T12:30:05Z

@olexii4 I watched the video, and filtering stacks in the list looks non intuitive to me. I'm wondering why list of stacks became empty when you entered "16" and then clicked on "Description"?

olexii4 · 2019-07-18T13:54:58Z

@akurinnoy The list of stacks became empty when I entered "16" and then click on "Description" because filtering depends on the field which was selected for sorting.
For example:

Sometimes we need display name, sometimes - description.

akurinnoy · 2019-07-18T14:03:45Z

@olexii4 That behavior is really not obvious to me. Clicking on a column title I suppose to change sort order but not to apply filter to that column. I would like to have a select box near "Search" field which allows to choose a column to apply a filtering and indicates where the filtering is already applied.

olexii4 · 2019-07-18T15:55:21Z

ci-test

che-bot · 2019-07-18T17:31:33Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13833
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2019-07-19T13:15:41Z

@akurinnoy I have updated

https://youtu.be/vbrRkRqtDYY

olexii4 · 2019-07-21T18:33:33Z

ci-test

che-bot · 2019-07-21T21:42:12Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13833
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2019-07-22T08:47:37Z

@slemeur I have updated
https://youtu.be/vbrRkRqtDYY

olexii4 · 2019-07-22T12:26:15Z

ci-test

slemeur · 2019-07-22T13:01:18Z

What link have you used for the devfile documentation?

olexii4 · 2019-07-22T13:58:16Z

@vitaliy-guliy

Existing UD filters are using only one column for searching

https://github.com/eclipse/che/blob/master/dashboard/src/app/workspaces/list-workspaces/list-workspaces.controller.ts#L102
https://github.com/eclipse/che/blob/master/dashboard/src/app/workspaces/workspace-details/workspace-plugins/workspace-plugins.controller.ts#L108
https://github.com/eclipse/che/blob/master/dashboard/src/app/factories/list-factories/list-factories.controller.ts#L92
https://github.com/eclipse/che/blob/master/dashboard/src/app/admin/user-management/user-management.controller.ts#L109

We have another issue for change this behaviorhttps://github.com//issues/13958

olexii4 · 2019-07-22T14:03:24Z

@slemeur I have used
https://redhat-developer.github.io/devfile/
for the devfile documentation

slemeur · 2019-07-22T14:20:55Z

Can you point to the documentation on che website pleasE?

slemeur · 2019-07-22T15:27:42Z

dashboard/src/app/stacks/stack-details/stack.html

@@ -47,7 +47,7 @@
                    editor-read-only="true"
                    editor-mode="text/x-yaml">
        </che-editor>
-          <a target="_blank" href="https://redhat-developer.github.io/devfile/">Docs: Devfile Structure</a>
+          <a ng-href="{{branding.docs.stack}}" target="_blank">Docs: Devfile Structure</a>


Where this link is going?

What? docs for Che 7 don't exist? they are..
https://github.com/eclipse/che-docs/tree/master/src/main/pages/che-7

But I would recommend you to give a look on the published one:
https://www.eclipse.org/che/docs/che-7/index.html

There is one page which should trigger your attention:
https://www.eclipse.org/che/docs/che-7/using-developer-environments-workspaces.html#making-a-workspace-portable-using-a-devfile_using-developer-environments-workspaces

Sorry for this

I was confusing with an old docks structure.
Thanks for your help with the needed docs link.

done
https://github.com/eclipse/che/blob/dd322d70eed43355f95c9504804e8f13df4b2e0b/dashboard/src/assets/branding/product.json#L23

rhopp · 2019-07-23T06:50:57Z

ci-test

che-bot · 2019-07-23T09:57:39Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13833
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

nickboldt

+0, others have already +1'd. Please rebase since this can't be merged as is.

nickboldt · 2019-07-23T16:29:16Z

Side note... the new Che 7 docs refer to the "Dashboard" not the "User Dashboard" or UD... is the acronym UD just a carryover from the Che 6 days, or is the docs team rebranding something they shouldn't be? @l0rd opinion?

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2019-07-23T17:24:35Z

ci-test

olexii4 · 2019-07-23T17:25:02Z

@nickboldt done

che-bot · 2019-07-23T18:09:55Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13833
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

l0rd · 2019-07-23T18:30:23Z

@nickboldt I am still calling it User Dashboard. Even when I am writing the docs.

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2019-07-24T13:44:44Z

@slemeur I have removed a select box for searching
https://youtu.be/OYP1QzlbNjA

che-bot · 2019-07-26T09:23:50Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13833
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 requested review from ashumilova, slemeur and akurinnoy July 12, 2019 12:33

olexii4 requested review from benoitf, l0rd, nickboldt and rhopp as code owners July 12, 2019 12:33

akurinnoy approved these changes Jul 15, 2019

View reviewed changes

olexii4 changed the title ~~Adapt Stacks in UD to Che 7~~ [WIP] Adapt Stacks in UD to Che 7 Jul 17, 2019

olexii4 force-pushed the CHE-13811 branch from c3f0455 to 85f2de7 Compare July 18, 2019 11:20

olexii4 requested a review from akurinnoy July 18, 2019 11:24

olexii4 force-pushed the CHE-13811 branch from 85f2de7 to f36fd3e Compare July 18, 2019 11:37

olexii4 changed the title ~~[WIP] Adapt Stacks in UD to Che 7~~ Adapt Stacks in UD to Che 7 Jul 18, 2019

olexii4 force-pushed the CHE-13811 branch from f923606 to 1110ace Compare July 21, 2019 18:29

olexii4 requested a review from evidolob July 22, 2019 08:38

olexii4 requested a review from Ohrimenko1988 as a code owner July 22, 2019 12:25

SkorikSergey approved these changes Jul 22, 2019

View reviewed changes

olexii4 mentioned this pull request Jul 22, 2019

All UD searches are using only one column for filtering #13958

Closed

slemeur reviewed Jul 22, 2019

View reviewed changes

nickboldt approved these changes Jul 23, 2019

View reviewed changes

olexii4 force-pushed the CHE-13811 branch from a424997 to bd8051a Compare July 23, 2019 16:47

olexii4 added 2 commits July 23, 2019 19:54

Adapt Stacks in UD to Che 7

35d15f3

Signed-off-by: Oleksii Orel <oorel@redhat.com>

Fix a dock link

dd322d7

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE-13811 branch from bd8051a to dd322d7 Compare July 23, 2019 17:19

ashumilova approved these changes Jul 24, 2019

View reviewed changes

Remove the select box

5839828

Signed-off-by: Oleksii Orel <oorel@redhat.com>

akurinnoy approved these changes Jul 24, 2019

View reviewed changes

evidolob approved these changes Jul 24, 2019

View reviewed changes

slemeur approved these changes Jul 25, 2019

View reviewed changes

olexii4 merged commit ca28a9b into master Jul 26, 2019

olexii4 deleted the CHE-13811 branch July 26, 2019 08:32

Adapt Stacks in UD to Che 7 #13833

Adapt Stacks in UD to Che 7 #13833

Conversation

olexii4 commented Jul 12, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

slemeur commented Jul 12, 2019 via email

olexii4 commented Jul 15, 2019

che-bot commented Jul 15, 2019

olexii4 commented Jul 18, 2019

olexii4 commented Jul 18, 2019

che-bot commented Jul 18, 2019

akurinnoy commented Jul 18, 2019

olexii4 commented Jul 18, 2019 • edited Loading

akurinnoy commented Jul 18, 2019

olexii4 commented Jul 18, 2019

che-bot commented Jul 18, 2019

olexii4 commented Jul 19, 2019 • edited Loading

olexii4 commented Jul 21, 2019

che-bot commented Jul 21, 2019

olexii4 commented Jul 22, 2019

olexii4 commented Jul 22, 2019

slemeur commented Jul 22, 2019

olexii4 commented Jul 22, 2019

olexii4 commented Jul 22, 2019

slemeur commented Jul 22, 2019

slemeur Jul 22, 2019

Choose a reason for hiding this comment

slemeur Jul 23, 2019

Choose a reason for hiding this comment

olexii4 Jul 23, 2019

Choose a reason for hiding this comment

olexii4 Jul 23, 2019

Choose a reason for hiding this comment

olexii4 Jul 23, 2019

Choose a reason for hiding this comment

rhopp commented Jul 23, 2019

che-bot commented Jul 23, 2019

nickboldt left a comment

Choose a reason for hiding this comment

nickboldt commented Jul 23, 2019

olexii4 commented Jul 23, 2019

olexii4 commented Jul 23, 2019

che-bot commented Jul 23, 2019

l0rd commented Jul 23, 2019

olexii4 commented Jul 24, 2019

che-bot commented Jul 26, 2019

olexii4 commented Jul 12, 2019 •

edited

Loading

olexii4 commented Jul 18, 2019 •

edited

Loading

olexii4 commented Jul 19, 2019 •

edited

Loading