Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the container-machine mapping predictably #13858

Merged
merged 7 commits into from
Jul 24, 2019
Merged

Store the container-machine mapping predictably #13858

merged 7 commits into from
Jul 24, 2019

Commits on Jul 16, 2019

  1. Store the container-machine mapping using a pair of annotations with a 

    predictable name length to prevent breaking the 63 character limit on the
k8s annotation names.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    f2e1b61 View commit details
    Browse the repository at this point in the history

  2. Add a simple test for reading out the machine name from the annotations. 

    Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    4fdc56a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Replace for loops with streams. Make the code a little bit more DRY. 

    Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    ca36b81 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Merge remote-tracking branch 'upstream/master' into bug/13303-annotat… 

    …ions-too-long

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    6508848 View commit details
    Browse the repository at this point in the history

  2. Simplify the impl by making sure we don't exceed the 63 char limit. 

    Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    0fc49b4 View commit details
    Browse the repository at this point in the history

  3. Improve the error message wording a little bit. 

    Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    3ddce7b View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Fix setting annotations for jwt-proxy pod 

    Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
    @sleshchenko
    sleshchenko committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    8e681cf View commit details
    Browse the repository at this point in the history