Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set wildcard '*' host name if key name start from 'default-' according to the the https://github.com/eclipse/che/issues/13494#issuecomment-512761661 #13901

Merged
merged 4 commits into from
Jul 18, 2019
Merged

Set wildcard '*' host name if key name start from 'default-' according to the the https://github.com/eclipse/che/issues/13494#issuecomment-512761661 #13901

merged 4 commits into from
Jul 18, 2019

Conversation

vparfonov
Copy link
Contributor

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

What does this PR do?

Set wildcard '*' host name if key name start from 'default-' according to the the #13494 (comment)
Example: if generate ssh key has name 'default-12345' to the ssh_config will be added:

host * 
IdentityFile /etc/ssh/default-12345/ssh-privatekey

What issues does this PR fix or reference?

#13494

Release Notes

Docs PR

@vparfonov
Set wildcard host name if key name start from 'default-' according to…
d8886af 
… the #13494 (comment)

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

vparfonov added 2 commits July 18, 2019 17:34
@vparfonov
Make secrets name for ssh key unique. Improve javadoc
fe1d462 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vparfonov
Remove debug stdout from test class
1927e77 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@rhopp
Copy link
Contributor

rhopp commented Jul 18, 2019

ci-test

rhopp
rhopp approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@rhopp rhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for including in 7.0. Please consult results of integration tests with somebody from QE before merging. Thx ;-)

@che-bot
Copy link
Contributor

che-bot commented Jul 18, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13901
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

@vparfonov: there is regression in Java selenium e2e tests results https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1921//Selenium_20tests_20report/ caused by ~100 test workspace failures, like the follow:

2019-07-18 17:29:47,686[9.4.74:8443/...]  [ERROR] [.i.k.KubernetesInternalRuntime 905]  - Unrecoverable event occurred during workspace 'workspace3jgvb0j2839gz3qv' startup: Failed, Failed to pull image "eclipse/ubuntu_jdk8": rpc error: code = Unknown desc = Error response from daemon: Get https://registry-1.docker.io/v2/eclipse/ubuntu_jdk8/manifests/latest: received unexpected HTTP status: 500 Internal Server Error, workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds
2019-07-18 17:29:47,687[aceSharedPool-0]  [WARN ] [.i.k.KubernetesInternalRuntime 245]  - Failed to start Kubernetes runtime of workspace workspace3jgvb0j2839gz3qv. Cause: Unrecoverable event occurred: 'Failed', 'Failed to pull image "eclipse/ubuntu_jdk8": rpc error: code = Unknown desc = Error response from daemon: Get https://registry-1.docker.io/v2/eclipse/ubuntu_jdk8/manifests/latest: received unexpected HTTP status: 500 Internal Server Error', 'workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds'
2019-07-18 17:29:47,969[aceSharedPool-0]  [INFO ] [o.e.c.a.w.s.WorkspaceRuntimes 856]   - Workspace 'user1563464702106:workspacep7olji' with id 'workspace3jgvb0j2839gz3qv' start failed

You can find full server logs here https://ci.codenvycorp.com/view/pr-builds/job/che-pullrequests-test-ocp/1921/Selenium_20tests_20report/che_server_logs.zip

@vparfonov
Copy link
Contributor Author

ci-test

@dmytro-ndp
Copy link
Contributor

@vparfonov: more details about start workspace error could be found in ocp-events.log inside https://ci.codenvycorp.com/view/pr-builds/job/che-pullrequests-test-ocp/1921/Selenium_20tests_20report/che_server_logs.zip:

eclipse-che   2m          2m           1         workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds.15b2909451974226        Pod                     spec.containers{container}                                    Normal    Pulling                          kubelet, localhost            pulling image "eclipse/ubuntu_jdk8"
eclipse-che   2m          2m           1         workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds.15b290946534d5cf        Pod                     spec.containers{container}                                    Warning   Failed                           kubelet, localhost            Failed to pull image "eclipse/ubuntu_jdk8": rpc error: code = Unknown desc = Error response from daemon: Get https://registry-1.docker.io/v2/eclipse/ubuntu_jdk8/manifests/latest: received unexpected HTTP status: 500 Internal Server Error
eclipse-che   2m          2m           1         workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds.15b2909465358a0d        Pod                     spec.containers{container}                                    Warning   Failed                           kubelet, localhost            Error: ErrImagePull
eclipse-che   31s         31s          1         workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds.15b290b131b14d01        Pod                                                                                   Warning   FailedMount                      kubelet, localhost            Unable to mount volumes for pod "workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds_eclipse-che(a2239284-a981-11e9-a962-1264e9c2e70a)": timeout expired waiting for volumes to attach/mount for pod "eclipse-che"/"workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds". list of unattached/unmounted volumes=[claim-che-workspace workspace3jgvb0j2839gz3qv-github-com ssshkeyconfigvolume che-workspace-token-lzzzl]
eclipse-che   2m          2m           1         workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4.15b29093b82e4f6a              ReplicaSet                                                                            Normal    SuccessfulCreate                 replicaset-controller         Created pod: workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds
eclipse-che   2m          2m           1         workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4.15b290946d94e152              ReplicaSet                                                                            Normal    SuccessfulDelete                 replicaset-controller         Deleted pod: workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4-jqcds
eclipse-che   2m          2m           1         workspace3jgvb0j2839gz3qv.dockerimage.15b29093b6b41a3c                         Deployment                                                                            Normal    ScalingReplicaSet                deployment-controller         Scaled up replica set workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4 to 1
eclipse-che   2m          2m           1         workspace3jgvb0j2839gz3qv.dockerimage.15b290946d079b9e                         Deployment                                                                            Normal    ScalingReplicaSet                deployment-controller         Scaled down replica set workspace3jgvb0j2839gz3qv.dockerimage-5f67799cd4 to 0

@vparfonov
Copy link
Contributor Author

thx @dmytro-ndp, probably some network issue, i will restart tests

@vparfonov
Fix typos
2979c53 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 18, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13901
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov vparfonov merged commit 6a93b8c into master Jul 18, 2019
@vparfonov vparfonov deleted the che#13494 branch July 18, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@rhopp rhopp rhopp approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@metlos metlos Awaiting requested review from metlos

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vparfonov @musienko-maxim @rhopp @che-bot @dmytro-ndp @sleshchenko @amisevsk