Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Happy-Path] Update chromedriver to version 76.0.0 #14144

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

Ohrimenko1988
Copy link
Contributor

Signed-off-by: Ihor Okhrimenko iokhrime@redhat.com

What does this PR do?

Update chromedriver to version 76.0.0

What issues does this PR fix or reference?

Issue: #14143

Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Copy link
Contributor Author

Ohrimenko1988 commented Aug 7, 2019

CQ in pending status https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20607

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 7, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 7, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@Ohrimenko1988
Copy link
Contributor Author

CQ has been approved, @dmytro-ndp @rhopp we have to update chrome browser version in the test image to "76" before merging

rhopp
rhopp previously approved these changes Aug 7, 2019
@rhopp
Copy link
Contributor

rhopp commented Aug 7, 2019

@Ohrimenko1988 Cannot you do that as part of this issue?

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Aug 7, 2019

I have started Happy path tests from this PR on eclipse/che-e2e:nightly, which has latest chrome driver inside https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/CHE-7-Maven-PR-build-checker-codenvy-slave9/56/

@Ohrimenko1988
Copy link
Contributor Author

@dmytro-ndp thank you

@che-bot
Copy link
Contributor

che-bot commented Aug 7, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@rhopp rhopp dismissed their stale review August 7, 2019 13:09

Didn't realize this has some other dependencies and is not ready to be merged.

@che-bot
Copy link
Contributor

che-bot commented Sep 6, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14144

@che-bot
Copy link
Contributor

che-bot commented Sep 6, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@Ohrimenko1988 Ohrimenko1988 merged commit 0ae75c0 into master Sep 6, 2019
@Ohrimenko1988 Ohrimenko1988 deleted the selen-update-driver branch September 6, 2019 14:11
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 6, 2019
@che-bot che-bot added this to the 7.2.0 milestone Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants