Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Stop and remove workspace on failed test #14246

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

Katka92
Copy link
Contributor

@Katka92 Katka92 commented Aug 15, 2019

What does this PR do?

Currently, when test is run in a --bail mode and fails, the workspace remains there. The goal of this PR is to create a mechanism that will stop and remove this workspace.
Add environment variable DELETE_WORKSPACE_ON_FAILED_TEST to turn on/off workspace deletion on failed tests.
The logic of creating a container is abstracted from inversify.config.ts to ContainerInitializer. This is the way that would allow us to rebind some classes in upstream.
To be able to dynamicly include the correct ContainerInitializer, the dynamic injection was allowed (change configuration of tslint).
Implementation of TestWorksapceUtil.ts binding were changed to use interface.

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 15, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14246

Signed-off-by: kkanova <kkanova@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14246
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

e2e/tslint.json Show resolved Hide resolved
@@ -80,4 +77,15 @@ export class TestWorkspaceUtil {
}
}

public async getIdOfRunningWorkspace(namespace: string): Promise<string> {
throw new Error("Method not implemented.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this approach. @rhopp What do you think about that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What approach do you mean? Throwing an error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean approach with the use of plugs instead of implementing realization

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say let's merge this PR, because I would prefer to not make this PR any bigger then it is and because we don't use/need these methods here right now and implement these methods in following PR (Katka will need this anyway for downstream work :-D).

@eclipse-che eclipse-che deleted a comment from che-bot Aug 19, 2019
@Katka92
Copy link
Contributor Author

Katka92 commented Aug 20, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@Katka92
Copy link
Contributor Author

Katka92 commented Aug 21, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14246

@nickboldt nickboldt merged commit 39bac9e into eclipse-che:master Aug 21, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 21, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 21, 2019
@Katka92 Katka92 deleted the e2e branch March 3, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants