Support single-host mode on the multi-user server #14335

metlos · 2019-08-26T15:27:15Z

What does this PR do?

Add a distinction between service name and path base in the external
server exposer to be able to correctly expose a service through a proxy
the async authentication in loader.js doesn't truncate the path
anymore so that it can correctly locate /jwt/auth even in single-host mode
enhance the jwt proxy configuration with the ability use custom uri
prefixes for the redirects on auth failure - this can be used to pass in
the information about the external path the proxy is available on even if
hidden behind a path rewriting ingress

Note that this depends changes in the che-jwtproxy component.

What issues does this PR fix or reference?

…ends changes in the che-jwtproxy component. * Add a distinction between service name and path base in the external server exposer to be able to correctly expose a service through a proxy * the async authentication in loader.js doesn't truncate the path anymore so that it can correctly locate /jwt/auth even in single-host mode * enhance the jwt proxy configuration with the ability use custom uri prefixes for the redirects on auth failure - this can be used to pass in the information about the external path the proxy is available on even if hidden behind a path rewriting ingress Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-08-26T15:28:05Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-08-26T15:28:35Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14335
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-08-27T17:01:46Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

...se/che/workspace/infrastructure/kubernetes/server/secure/jwtproxy/JwtProxyConfigBuilder.java

metlos · 2019-08-28T08:10:21Z

ci-test

metlos · 2019-08-28T08:12:21Z

crw-ci-test

...ipse/che/workspace/infrastructure/kubernetes/server/secure/jwtproxy/JwtProxyProvisioner.java

che-bot · 2019-08-28T08:27:20Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14335

che-bot · 2019-08-28T08:37:51Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14335

che-bot · 2019-08-28T08:43:03Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

SkorikSergey · 2019-08-28T09:27:27Z

@metlos : about failed deployment of Che here in test results:
it was because of Che deployment error:

2019-08-28 09:14:16,959[ost-startStop-1]  [INFO ] [.e.c.c.d.JNDIDataSourceFactory 63]   - This=org.eclipse.che.core.db.postgresql.PostgreSQLJndiDataSourceFactory@17483064 obj=ResourceRef[className=javax.sql.DataSource,factoryClassLocation=null,factoryClassName=org.apache.naming.factory.ResourceFactory,{type=scope,content=Shareable},{type=auth,content=Container},{type=singleton,content=true},{type=factory,content=org.eclipse.che.api.CommonJndiDataSourceFactory}] name=che Context=org.apache.naming.NamingContext@6dbb94d7 environment={}
--
  2019-08-28 09:14:19,196[ost-startStop-1]  [ERROR] [o.a.c.c.C.[.[localhost].[/api] 4798] - Exception sending context initialized event to listener instance of class [org.eclipse.che.inject.CheBootstrap]
  com.google.inject.CreationException: Unable to create injector, see the following errors:
   
  1) No implementation for org.eclipse.che.workspace.infrastructure.kubernetes.server.external.IngressServiceExposureStrategy was bound.
  while locating org.eclipse.che.workspace.infrastructure.kubernetes.server.external.IngressServiceExposureStrategy
  for the 3rd parameter of org.eclipse.che.workspace.infrastructure.kubernetes.server.secure.jwtproxy.JwtProxyProvisioner.<init>(JwtProxyProvisioner.java:122)
  at org.eclipse.che.workspace.infrastructure.kubernetes.server.secure.jwtproxy.factory.JwtProxyProvisionerFactory.create(JwtProxyProvisionerFactory.java:1)
  at com.google.inject.assistedinject.FactoryProvider2.initialize(FactoryProvider2.java:716)
  at org.eclipse.che.api.deploy.WsMasterModule.configureJwtProxySecureProvisioner(WsMasterModule.java:425) (via modules: org.eclipse.che.api.deploy.WsMasterModule -> com.google.inject.assistedinject.FactoryModuleBuilder$1)
  
  1 error

metlos · 2019-08-28T09:30:08Z

Thanks for investigating @SkorikSergey. That is rather weird, I'll take a look.

the auth request. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

* provided overriden bindings for OpenShift infra * Renamed IngressServiceExposureStrategy to ExternalServiceExposureStrategy so that it is not confusing on OpenShift where ingresses are not used * Made the cookie path server-strategy sensitive Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-08-29T20:34:18Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

SkorikSergey · 2019-08-30T06:39:10Z

ci-test

che-bot · 2019-08-30T07:23:14Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

metlos · 2019-08-30T09:43:00Z

ci-test

metlos · 2019-09-05T09:02:00Z

ci-test

metlos · 2019-09-05T09:06:35Z

crw-ci-test

che-bot · 2019-09-05T09:13:42Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14335
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-09-05T10:45:17Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

metlos · 2019-09-05T14:36:31Z

ci-test

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

metlos · 2019-09-06T09:45:34Z

ci-test

…-user Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-09-06T10:35:13Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-09-09T06:56:36Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14335

che-bot · 2019-09-09T07:35:16Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

dmytro-ndp · 2019-09-09T08:35:58Z

ci-test

che-bot · 2019-09-09T09:26:34Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-09-09T12:46:28Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14335
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

…-user Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-09-09T13:14:28Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

che-bot · 2019-09-09T13:41:30Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14335
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-09-09T14:17:21Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14335
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

dmytro-ndp · 2019-09-09T16:41:33Z

@metlos: about this Happy path tests failure - it was changes in upstream Theia project, which affected our tests.
There is fixup already in master. Please, take changes into PR.

…-user Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

che-bot · 2019-09-10T07:25:27Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14335

che-bot · 2019-09-10T07:56:40Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14335

metlos requested review from amisevsk, l0rd, nickboldt, rhopp, skabashnyuk and sleshchenko as code owners August 26, 2019 15:27

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 26, 2019

Formatting and test fixes.

78c8d02

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

skabashnyuk approved these changes Aug 28, 2019

View reviewed changes

sleshchenko reviewed Aug 28, 2019

View reviewed changes

...se/che/workspace/infrastructure/kubernetes/server/secure/jwtproxy/JwtProxyConfigBuilder.java Show resolved Hide resolved

sleshchenko reviewed Aug 28, 2019

View reviewed changes

...ipse/che/workspace/infrastructure/kubernetes/server/secure/jwtproxy/JwtProxyProvisioner.java Outdated Show resolved Hide resolved

metlos mentioned this pull request Aug 29, 2019

Support single-host mode of Che server. eclipse-che/che-jwtproxy#11

Merged

metlos added 2 commits August 29, 2019 21:49

Make sure pathname doesn't contain duplicated slashes when constructing

5c66420

the auth request. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

skabashnyuk mentioned this pull request Sep 5, 2019

Multiuser-OpenShift on OpenShift behind Proxy not starting Workspaces #14052

Closed

skabashnyuk reviewed Sep 6, 2019

View reviewed changes

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties Outdated Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into single-host-multi…

2e1e057

…-user Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

Use the fixed version of the JWT proxy image.

3d94934

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

The cookie paths are server-strategy dependent.

1c1969e

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

Merge remote-tracking branch 'upstream/master' into single-host-multi…

e14276a

…-user Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

amisevsk approved these changes Sep 9, 2019

View reviewed changes

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into single-host-multi…

20d9ed8

…-user Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

metlos merged commit 154d668 into eclipse-che:master Sep 10, 2019

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 10, 2019

che-bot added this to the 7.2.0 milestone Sep 10, 2019

metlos mentioned this pull request Sep 10, 2019

Support single-host/default-host in multi-user server mode #14189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support single-host mode on the multi-user server #14335

Support single-host mode on the multi-user server #14335

metlos commented Aug 26, 2019

che-bot commented Aug 26, 2019

che-bot commented Aug 26, 2019

che-bot commented Aug 27, 2019

metlos commented Aug 28, 2019

metlos commented Aug 28, 2019

che-bot commented Aug 28, 2019

che-bot commented Aug 28, 2019

che-bot commented Aug 28, 2019

SkorikSergey commented Aug 28, 2019

metlos commented Aug 28, 2019

che-bot commented Aug 29, 2019

SkorikSergey commented Aug 30, 2019

che-bot commented Aug 30, 2019

metlos commented Aug 30, 2019

metlos commented Sep 5, 2019

metlos commented Sep 5, 2019

che-bot commented Sep 5, 2019

che-bot commented Sep 5, 2019

metlos commented Sep 5, 2019

metlos commented Sep 6, 2019

che-bot commented Sep 6, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

dmytro-ndp commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

dmytro-ndp commented Sep 9, 2019

che-bot commented Sep 10, 2019

che-bot commented Sep 10, 2019

Support single-host mode on the multi-user server #14335

Support single-host mode on the multi-user server #14335

Conversation

metlos commented Aug 26, 2019

What does this PR do?

What issues does this PR fix or reference?

che-bot commented Aug 26, 2019

che-bot commented Aug 26, 2019

che-bot commented Aug 27, 2019

metlos commented Aug 28, 2019

metlos commented Aug 28, 2019

che-bot commented Aug 28, 2019

che-bot commented Aug 28, 2019

che-bot commented Aug 28, 2019

SkorikSergey commented Aug 28, 2019

metlos commented Aug 28, 2019

che-bot commented Aug 29, 2019

SkorikSergey commented Aug 30, 2019

che-bot commented Aug 30, 2019

metlos commented Aug 30, 2019

metlos commented Sep 5, 2019

metlos commented Sep 5, 2019

che-bot commented Sep 5, 2019

che-bot commented Sep 5, 2019

metlos commented Sep 5, 2019

metlos commented Sep 6, 2019

che-bot commented Sep 6, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

dmytro-ndp commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

dmytro-ndp commented Sep 9, 2019

che-bot commented Sep 10, 2019

che-bot commented Sep 10, 2019