Adapt test after updating Monaco editor #14523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musienko-maxim
requested review from
l0rd,
nickboldt,
Ohrimenko1988 and
rhopp
as code owners
che-bot
added
status/code-review
Signed-off-by: musienko maksym <mmusiien@redhat.com>
musienko-maxim
force-pushed
the
che#14512
branch
from
ea7481c
to
a588946
Compare
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
dmytro-ndp
approved these changes
Sep 12, 2019
che-bot
removed
the
status/code-review
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merge Theia PR:
Monaco editor was updated. It reflected on che e2e test. We got some changes in the DOM and new issue: #14520
What does this PR do?
This PR adapt the tests to to the new changes. The code navigation part was skipped as temporary solution. We are going to implement workaround: #14522
What issues does this PR fix or reference?
#14512