Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides RELEASE.md file with the release instructions. #15668

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

vparfonov
Copy link
Contributor

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

What does this PR do?

Provides RELEASE.md file with the release instructions.

What issues does this PR fix or reference?

Release Notes

Docs PR

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@ibuziuk
Copy link
Member

ibuziuk commented Jan 13, 2020

@vparfonov what about the bug-fix / service release process? are you going to provide this info in a separate PR ?

@vparfonov
Copy link
Contributor Author

@vparfonov what about the bug-fix / service release process? are you going to provide this info in a separate PR ?

Good catch, I will add here

@ibuziuk
Copy link
Member

ibuziuk commented Jan 13, 2020

@vparfonov does che-parent / che-docs update suppose to be covered by this RELEASE.md?

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 20, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 20, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Jan 20, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

@nickboldt
Copy link
Contributor

OH NO! Happy path tests are failing for a new, document-only file.

Why are the happy paths failing for a file that isn't part of the build?

* `git merge -X theirs {branchname}`
* `git push -f`
##### 6. Close/release repository on Nexus
https://oss.sonatype.org/#stagingRepositories
Copy link
Contributor

@nickboldt nickboldt Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be scripted? Who has login/nexus credentials to make such a change?

* on MacOS: `set_tag_version_images_macos.sh {tag}`
* `git commit`
* `git push`
##### 4. Start pre-release testing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to job? trigger instructions? Who to talk to? deadline for review? Criteria for rejection/approval?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/eclipse/che-machine-exec/blob/master/RELEASE.md for example of how to link to the job(s) that run the builds/tests so we an immediate see status.

1 Update deploy_che.sh (should be deprecated soon - https://github.com/eclipse/che/issues/14069) default environment variables
2 Update default version of plugins and editors in che.properties to released tag e.g `7.7.0`
3 Update Helm charts with released tag e.g `7.7.0`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you list actual files that are changed or provide a link to PRs for 7.7.0 and 7.7.1?

* Update dependencies: `sed -i -e "s#{version_old}#{next_version}#" pom.xml`
* `git commit`
* `git push --set-upstream origin set_next_version_in_master_{next_version}`
* Create PR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to samples please. See https://github.com/eclipse/che-machine-exec/blob/master/RELEASE.md for examples of how to do this.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but needs fleshing out with more details, links, samples, etc.

@nickboldt
Copy link
Contributor

Is this RELEASE.md for all three Che projects (parent, docs, che) ? What about che-dev or che-lib? Will you also create RELEASE.md files for those repos?

Or does the Che release process handle all 4 projects in one operation?

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking so we can merge; remaining items to be done as enhancement as part of the doc generated from tomorrow's collab release with @mkuznyetsov and @vparfonov

@nickboldt nickboldt merged commit 6e941bd into master Jan 28, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 28, 2020
@che-bot che-bot added this to the 7.8.0 milestone Jan 28, 2020
@vparfonov vparfonov deleted the release_md branch January 28, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants