Watch and provide startup logs #15988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
che-bot
added
status/code-review
metlos
reviewed
Feb 13, 2020
...ava/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesDeployments.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
...pse/che/workspace/infrastructure/kubernetes/namespace/log/PodLogHandlerToEventPublisher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…sted in Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…ool... can this thing get any better? Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…w responsible for handling just single log messages Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
metlos
reviewed
Feb 14, 2020
...ava/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesDeployments.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/log/LogWatcher.java
Outdated
Show resolved
Hide resolved
# Conflicts: # infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/KubernetesInternalRuntime.java
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…ethod Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Watch the logs of all containers in workspace pod during workspace startup. Feature is disabled by default. It can be enabled on workspace startup REST API with new query parameter
debug-workspace-start. If it is set to true, logs will be watched and printed during the startup.so API call looks like this:
<che-host>/api/workspace/{id}/runtime?debug-workspace-start=trueTODO:
create config properties, most important for completely disable the feature, should be default true or false ???configurable with devfile attributeWhat issues does this PR fix or reference?
#15983
Docs PR
this adds an option on che-server API, docs should be part of UI based tasks #16050 #16063