Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the get starting page title #16136

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Fix the get starting page title #16136

merged 1 commit into from
Feb 26, 2020

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Feb 25, 2020

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix the Get Started page title.

What issues does this PR fix or reference?

#16135

@olexii4
fix the get starting page title
a9f3976 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 changed the title fix the get starting page title Fix the get starting page title Feb 25, 2020
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Feb 25, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 25, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Feb 25, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@amisevsk
Copy link
Contributor

cc: @nickboldt This is required for 7.9.1, right?

@nickboldt nickboldt mentioned this pull request Feb 25, 2020
Closed
24 tasks
nickboldt
nickboldt approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems simple enough.

@olexii4
Copy link
Contributor Author

olexii4 commented Feb 26, 2020

crw-ci-test

@olexii4
Copy link
Contributor Author

olexii4 commented Feb 26, 2020

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@SkorikSergey
Copy link
Contributor

[ci-test]

@olexii4 olexii4 merged commit 2d41866 into master Feb 26, 2020
@olexii4 olexii4 deleted the CHE-16135 branch February 26, 2020 11:15
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 26, 2020
@che-bot che-bot added this to the 7.10.0 milestone Feb 26, 2020
@sleshchenko
Copy link
Member

cc @nickboldt

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@nickboldt
Copy link
Contributor

Thanks for the fix!

In future, when you KNOW a fix is needed in the maintenance branch, can you ensure you cherry pick it across to the .x branch too?

That way I don't have to figure out what you did, where, and track down the commit SHA to copy it over to the .x branch. Thanks!

Cherry picked in b52af96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@amisevsk amisevsk amisevsk approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@benoitf benoitf benoitf approved these changes

@nickboldt nickboldt nickboldt approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

@l0rd l0rd Awaiting requested review from l0rd

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.10
Development

Successfully merging this pull request may close these issues.
8 participants
@olexii4 @che-bot @amisevsk @SkorikSergey @sleshchenko @nickboldt @benoitf @akurinnoy