Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Selenium] Set application.confirmExit property to 'never' by default #16146

Merged
merged 3 commits into from
Feb 27, 2020
Merged

[Selenium] Set application.confirmExit property to 'never' by default #16146

merged 3 commits into from
Feb 27, 2020

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

Set application.confirmExit property to never as default.

What issues does this PR fix or reference?

#16100

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Feb 26, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@SkorikSergey
Copy link
Contributor Author

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@SkorikSergey
Copy link
Contributor Author

[ci-build]

@SkorikSergey
Copy link
Contributor Author

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@SkorikSergey
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@SkorikSergey SkorikSergey marked this pull request as ready for review February 27, 2020 12:33
@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Feb 27, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@SkorikSergey SkorikSergey merged commit ef89643 into master Feb 27, 2020
@SkorikSergey SkorikSergey deleted the disableConfirmExitIdeProperty branch February 27, 2020 15:04
@SkorikSergey SkorikSergey removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkorikSergey @che-bot @dmytro-ndp