Make single user work with secure components exposed through localhost only #16227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into the workspace pod. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
to the hardcoded values in the che-jwtproxy image. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
any authentication out. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
che-bot
added
status/code-review
This was referenced Mar 4, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
This comment has been minimized.
This comment has been minimized.
|
[ci-test] |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful: |
sleshchenko
reviewed
Mar 5, 2020
...re-api-model/src/main/java/org/eclipse/che/api/core/model/workspace/config/ServerConfig.java
Show resolved
Hide resolved
...java/org/eclipse/che/workspace/infrastructure/kubernetes/server/secure/ProxyProvisioner.java
Show resolved
Hide resolved
...re/kubernetes/server/secure/jwtproxy/factory/PassThroughProxySecureServerExposerFactory.java
Outdated
Show resolved
Hide resolved
.../workspace/infrastructure/kubernetes/server/secure/jwtproxy/PassThroughProxyProvisioner.java
Show resolved
Hide resolved
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
…ents. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
metlos
requested review from
amisevsk,
ibuziuk,
l0rd,
nickboldt and
rhopp
as code owners
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
[ci-build] |
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
[ci-build] |
skabashnyuk
reviewed
Mar 5, 2020
| private final boolean detectCookieAuth; | ||
|
|
||
| /** | ||
| * Constructor! |
.../workspace/infrastructure/kubernetes/server/secure/jwtproxy/PassThroughProxyProvisioner.java
Show resolved
Hide resolved
|
[ci-test] |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful: |
mshaposhnik
approved these changes
Mar 6, 2020
skabashnyuk
approved these changes
Mar 6, 2020
che-bot
removed
the
status/code-review
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the default single user deployment configure jwt proxy in such a way that it essentially acts as a passthrough proxy (excluding
/from auth).Some code consolidation has been done to make this DRY.
Additionally, the JWT proxy is made to honor the side car image pull policy setting and completely configures the JWT proxy pod so that we don't depend on the defaults hardcoded in the jwt proxy image.
What issues does this PR fix or reference?
#15651 #16053