Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript tests - fix removing workspace #16561

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

Katka92
Copy link
Contributor

@Katka92 Katka92 commented Apr 7, 2020

What does this PR do?

Fix the deletion of a workspace via UI.

What issues does this PR fix or reference?

The new pop-up is present when users tires to delete a workspace.
Now the user needs to select the checkbox and click on a Delete button.

EDIT: related issue #8542

@che-bot che-bot added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Apr 7, 2020
Copy link
Contributor

@Ohrimenko1988 Ohrimenko1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting workspace by checkbox and deleting button doesn't work in 100% cases. In the part of the cases workspace keep displaying and correct displaying require window refreshing.
So that is why I disagree with this approach and strongly recommend keep current approach.

@Katka92
Copy link
Contributor Author

Katka92 commented Apr 7, 2020

Current flow is to go to the workspace details and there click Delete button. After that, a new pop-up appears, where the user needs to select the checkbox and press again Delete button.
I've fixed the part with the pop-up, the flow stays the same.
Current flow is not working as nightly tests are failing on that, so if you don't like this approach, please suggest something else.

@che-bot
Copy link
Contributor

che-bot commented Apr 7, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@Ohrimenko1988
Copy link
Contributor

Thank you for the explanation, approved.

@Katka92 Katka92 merged commit 7580ee9 into eclipse-che:master Apr 7, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants