che #15906 Disabling 'che.workspace.stop.role.enabled' by default #16725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
ibuziuk
requested review from
l0rd,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
status/code-review
|
[ci-test] |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
@tomgeorge it looks the configuration will only work when OpenShift OAth is enabled |
tomgeorge
approved these changes
Apr 23, 2020
|
E2E tests of Eclipse Che Multiuser on OCP has been successful: |
SkorikSergey
approved these changes
Apr 23, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Buziuk ibuziuk@redhat.com
Hot-fix for #16724
What does this PR do?
Disabling 'che.workspace.stop.role.enabled' by default
the logic with granting stop-workspace role will not work in all the cases
What issues does this PR fix or reference?
#16724