Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che #15906 setting 'che.workspace.stop.role.enabled' to true #16804

Merged
merged 1 commit into from
May 4, 2020

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Apr 29, 2020

What does this PR do?

setting 'che.workspace.stop.role.enabled' to true

After #16735 we should be good to set the property to true by default

What issues does this PR fix or reference?

fixup #15906

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk requested a review from tomgeorge April 29, 2020 16:40
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Apr 29, 2020
@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 29, 2020

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Apr 29, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Apr 29, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@ibuziuk ibuziuk merged commit dcf6701 into eclipse-che:master May 4, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 4, 2020
@benoitf benoitf added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants