Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics role #18268

Closed
wants to merge 1 commit into from
Closed

Add metrics role #18268

wants to merge 1 commit into from

Conversation

svor
Copy link
Contributor

@svor svor commented Nov 3, 2020

Signed-off-by: svor vsvydenk@redhat.com

What does this PR do?

  • Adds new verb get for workspace-view role to get an information about limited resources
  • Adds new role workspace-metrics to get an information from Metric server

What issues does this PR fix or reference?

#17205

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@svor
Add metrics role
5b87a77 
Signed-off-by: svor <vsvydenk@redhat.com>
@svor svor self-assigned this Nov 3, 2020
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. labels Nov 3, 2020
@svor
Copy link
Contributor Author

svor commented Nov 3, 2020

[crw-ci-test]

@eclipse-che eclipse-che deleted a comment from che-bot Nov 3, 2020
@che-bot
Copy link
Contributor

che-bot commented Nov 3, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@svor svor closed this Nov 5, 2020
@svor svor deleted the sv/metricsRole branch November 5, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@svor svor

Labels
kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svor @che-bot