Fix failing Che when used external OIDC provider. Port to 7.23.x #18631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix failing Che when used external OIDC provider. Refactor code related to internal network. Add more tests and java docs. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
mshaposhnik,
nickboldt and
sparkoo
as code owners
che-bot
added
target/branch
tolusha
approved these changes
Dec 16, 2020
ibuziuk
approved these changes
Dec 16, 2020
|
Retested manually one more time for 7.23.x with Openshift 4. |
AndrienkoAleksandr
deleted the
fixFailingCheWithOIDCProviderPortTo7.23.x
branch
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix failing Che when used external OIDC provider. Refactor code related to internal network. Add more tests and java docs.
What issues does this PR fix or reference?
#18553
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.