CHE-1819: fix NPE when unresolved project is deleted #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svor
changed the title
|
ok |
| @@ -414,6 +414,10 @@ public Project getRootProject() { | |||
| } | |||
| } | |||
|
|
|||
| if (currentResources[0] == null) { | |||
There was a problem hiding this comment.
What does it actually mean?
There was a problem hiding this comment.
It means that current resource (selected resource) is null. In this class
currentResources[0] == currentResource
I've made some changes and now it's more clear, I hope.
Signed-off-by: Valeriy Svydenko <vsvydenko@codenvy.com>
|
Build # 1308 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1308/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix NPE after deleting unresolved multi-module project.
Show notification with the number of modules which were deleted.
What issues does this PR fix or reference?
#1819
Previous Behavior
After deleting multi-module project the process of resolving dependencies is continued and threw many NPEs
New Behavior
This content may also be included in the release notes.
After deleting multi-module project: project is deleted without exceptions and the process of resolving dependencies is ended
Tests written?
No
Please review @vparfonov