Add release workflow for che parent and server #18909
Conversation
che-bot
added
status/code-review
nickboldt
changed the title
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
mkuznyetsov
changed the title
| with: | ||
| repository: eclipse/che-parent | ||
| token: {{ secrets.CHE_BOT_GITHUB_TOKEN }} | ||
| path: che-parent |
There was a problem hiding this comment.
does this need fetch-depth:0 too?
| - name: Check existing tag | ||
| run: | | ||
| if [[ "$FORCE_RECREATE_TAGS" == "false" ]] && [[ $(cd che && git ls-remote --exit-code origin refs/tags/${{ github.event.inputs.version}} ]]; then | ||
| echo "cannot create release, when tag already exists" |
There was a problem hiding this comment.
Might be better formatted as an error, eg.,
echo "[ERROR] Tag ${{ github.event.inputs.version}} already exists - cannot re-release. Use 'forceRecreateTags:true' if you want to force a re-release to this tag."
.github/workflows/release.yml
Outdated
| architecture: x64 | ||
| - name: Set up environment | ||
| run: | | ||
| # install more repos |
There was a problem hiding this comment.
update doesn't install repos... it updates.
| sudo apt-get update -y || true | ||
| # install more dependencies | ||
| sudo apt-get -y -q install wget curl bash git | ||
| java -version |
There was a problem hiding this comment.
you're checking java version here but didn't install it?
There was a problem hiding this comment.
it would be installed through respective github action earier
There was a problem hiding this comment.
sure but you're ALSO outputting version 3 lines lower.
.github/workflows/release.yml
Outdated
| javac -version | ||
| which javac | ||
|
|
||
| # do we need any of these? |
There was a problem hiding this comment.
if these were commented out in the last che 7.25.x releases, we can probably remove them, right?
make-release.sh
Outdated
| @@ -3,162 +3,405 @@ | |||
| # Used to create branch/tag, update versions in pom.xml | |||
| # and and trigger release by force pushing changes to the release branch | |||
There was a problem hiding this comment.
are we still using the release branch?
make-release.sh
Outdated
| # cleanup tmp dir | ||
| # cd /tmp && rm -fr "$TMP" | ||
|
|
||
| # TODO ensure usage of respective bugfix branches |
| set +x | ||
| # TODO should this be node 12? | ||
| curl -sL https://deb.nodesource.com/setup_10.x | sudo -E bash - | ||
| sudo apt-get install -y nodejs |
There was a problem hiding this comment.
should this move to a yaml step?
| pushd che-parent >/dev/null | ||
| # Install previous version, in case it is not available in central repo | ||
| # which is needed for dependent projects | ||
| mvn clean install |
There was a problem hiding this comment.
why do we build the che-parent TWICE? Surely only one version is needed?
| @@ -0,0 +1,116 @@ | |||
| # | |||
| # Copyright (c) 2020 Red Hat, Inc. | |||
There was a problem hiding this comment.
omg 2020 was SOOO last year. :)
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
che-bot
removed
the
status/code-review
What does this PR do?
Move che parent & server release workflow from che-release project to che-server
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#18780
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.