Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm chart] Add RBAC templates for the resource-monitor. #18998

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[helm chart] Add RBAC templates for the resource-monitor. #18998

merged 1 commit into from
Feb 23, 2021

Conversation

monaka
Copy link
Member

@monaka monaka commented Feb 6, 2021

This will fix eclipse/che 18812.

Signed-off-by: Masaki Muranaka monaka@monami-ya.com

What does this PR do?

Adds RBAC templates to the Helm chart for the resource-monitor.

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

#18812

How to test this PR?

  1. Deploy with the chart
  2. Boot the workspace and check your screen.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Feb 6, 2021
@monaka monaka added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Feb 6, 2021
@monaka
Copy link
Member Author

monaka commented Feb 6, 2021

I suppose it should be added similar patches to OpenShift. But I'm not familiar to it...

@sleshchenko
Copy link
Member

@monaka AFAIK Hosted Che uses OpenShift templates, so this PR won't fix

This will fix #18812.

But in general this PR makes sense I believe.

@sleshchenko sleshchenko requested a review from svor February 8, 2021 08:53
@monaka
Copy link
Member Author

monaka commented Feb 9, 2021

@sleshchenko Ah, my bad. This PR don't fix #18812 and It may be some helps fixing it.
The commit message will be fixed until this PR is approved.

refs #18812.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@tolusha tolusha merged commit aecad79 into eclipse-che:master Feb 23, 2021
@che-bot che-bot added this to the 7.27 milestone Feb 23, 2021
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants