-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set public url for public keycloak endpoints #19096
Conversation
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
@tolusha: about failure: #19096 (comment) : |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
[crw-ci-test] |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
@dmytro-ndp |
[crw-ci-test --rebuild] |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
[crw-ci-test] |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
@tolusha: FYI: there is new commit in master branch, which has to stabilize PR Happy path tests. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
* Set public url for public keycloak endpoints Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Keycloak of v6.0.1 and v7.0.1 versions behaviors differently.
6.0.1
return public urls independently if request to keycloak was done using public [1] or internal [2] urls7.0.1
return internal urls (http://keycloak.eclipse-che.svc:8080/auth/...) if request was done using internal url [2]This PR make sure that
OIDCInforProvier
stores public keycloak urls.[1] https://github.com/eclipse/che/blob/9e4c4f1890e7a80dc403730edcbb4a5f6a85c480/multiuser/keycloak/che-multiuser-keycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/OIDCInfoProvider.java#L49
[2] https://github.com/eclipse/che/blob/9e4c4f1890e7a80dc403730edcbb4a5f6a85c480/multiuser/keycloak/che-multiuser-keycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/OIDCInfoProvider.java#L54
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1509
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.