Remove code that supports namespace strategies other than per-user

[skabashnyuk]

What does this PR do?

Remove code that supports namespace strategies other than per-user
Documentation changes - in progress....

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes #19536

How to test this PR?

1. Deploy che-server image quay.io/skabashn/che-server:che19536
2. Should create per-user k8s namespace by default
3. Setup oc patch checluster eclipse-che -n eclipse-che --type=json -p '[{"op": "replace", "path": "/spec/devWorkspace/enable", "value": true}]
4. Che server startup should fail with message Only 'per user' is allowed.Using the <username> or <userid> placeholder is required in the 'che.infra.kubernetes.namespace.default' parameter. The current value is: '<workspaceid>-che'

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[themr0c]

ACK for the che.properties changes

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• image: quay.io/crw_pr/che-server:19763

Tested with Eclipse Che on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[sparkoo]

tested on minikube with multiple namespace configurations and pre-created namespaces, works fine.

Do you plan to update che-operator code to reflect these changes? For example che-operator sets CHE_INFRA_KUBERNETES_NAMESPACE_ALLOW__USER__DEFINED in che configmap.

[sparkoo]

are we sure about removing allow_user_defined ? I can imagine scenarios where admin pre-create more namespaces for single user.

[skabashnyuk]

@sparkoo

Do you plan to update che-operator code to reflect these changes? For example che-operator sets CHE_INFRA_KUBERNETES_NAMESPACE_ALLOW__USER__DEFINED in che configmap.

I hope that would be a part of the job that @tolusha will do in eclipse-che/che-operator#818.

are we sure about removing allow_user_defined ?

I think we should be strict: one user -> one k8s namespace.

I can imagine scenarios where admin pre-create more namespaces for single user.

I think that would be a misconfiguration.

[tolusha]

@skabashnyuk
I will update operator not to set CHE_INFRA_KUBERNETES_NAMESPACE_ALLOW__USER__DEFINED in che configmap.

[skabashnyuk]

docs pr eclipse-che/che-docs#1983