Introduce codenvy/che-test and codenvy/che-file docker images #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Project: https://github.com/jakearchibald/ES6-Promise | ||
| // Definitions by: François de Campredon <https://github.com/fdecampredon/>, vvakame <https://github.com/vvakame> | ||
| // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | ||
|
|
There was a problem hiding this comment.
What is the origin of this file?
There was a problem hiding this comment.
deleted check-in, will be part of only a compile time type dependencies
benoitf
changed the title
benoitf
added
the
status/code-review
| COPY lib/typescript/bin /bin | ||
| ADD che-file/src/che.properties /lib/che.properties | ||
|
|
||
| ENTRYPOINT ["/bin/che", "che-file"] |
| return this.ip; | ||
| } | ||
|
|
||
| } |
|
lgtm - congratulations! |
20 tasks
|
if review is OK I could then merge this PR and we can keep adding changes on them as ppl will be able to test it |
|
ok to merge |
First one is codenvy/che-test allowing to check a local or remote Eclipse Che instance by creating a workspace, starting it and displaying console output The other one is codenvy/che-file allowing to boot a local Eclipse Che by using a local directory. It will mount in Che this local folder as being a project. Change-Id: Ie794b41f89608f86e589f1aeea06d63f0d9f2edc Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
6 tasks
|
Build # 1347 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1347/ to view the results. |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It provides two docker images
codenvy/che-test
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock codenvy/che-test <post-check> [URL of Che/Codenvy] [login] [password]Which create a workspace, start it and display log
codenvy/che-file
still in wip with a run syntax close to
docker run -v /var/run/docker.sock:/var/run/docker.sock -v "$PWD":"$PWD" --rm codenvy/che-file $PWD <init|up>
Tests written?
No