Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize check of build and run application in Happy path tests #19909

Merged
merged 12 commits into from
Jun 7, 2021
Merged

Stabilize check of build and run application in Happy path tests #19909

merged 12 commits into from
Jun 7, 2021

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Jun 2, 2021 •
edited
Loading

What does this PR do?

It is:

  1. Adding timeout in Happy path tests to wait on opening application in Preview Widget.
  2. Removing outdated workaround to After updating Monaco Editor some Keybindings has collision for Java LS #14520
  3. Adding workaround to Happy path test are failing on "Validation of debug functionality" because there is no debug configuration #19887
  4. Using "che-e2e:next" instead of "che-e2e:nightly" in Eclipse Che E2E testing CI jobs

Screenshot/screencast of this PR

screenshot-Check_the_running_application

What issues does this PR fix or reference?

Closes: #19895, #19886
Relates: #19887, #19905

How to test this PR?

Run Happy path tests

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. kind/bug Outline of a bug - must adhere to the bug report template. labels Jun 2, 2021
@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Jun 4, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 4, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@eclipse-che eclipse-che deleted a comment from che-bot Jun 6, 2021
@eclipse-che eclipse-che deleted a comment from che-bot Jun 6, 2021
@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@eclipse-che eclipse-che deleted a comment from che-bot Jun 6, 2021
@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@dmytro-ndp
Add workaround to #19887
bfdee69 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@eclipse-che eclipse-che deleted a comment from che-bot Jun 6, 2021
@eclipse-che eclipse-che deleted a comment from che-bot Jun 6, 2021
@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

2 similar comments
@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@dmytro-ndp dmytro-ndp changed the title Add timeout in Happy path tests to wait on opening application in Preview Widget Stabilize check of build and run application in Happy path tests Jun 6, 2021
@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@dmytro-ndp
Increase timeout of waiting on 'SpringApplication.class' file opened
d8c8c8f 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@dmytro-ndp
Copy link
Contributor Author

@Katka92, @Ohrimenko1988, @artaleks9: could you, please, review new changes in #19909?
Sorry for asking about it again - it had been taken more time to ensure the fix was just enough for stabilizing of Happy path tests, and I had decided to include one more fix to stabilize verification of application build #19886, and to add workaround to debug flakiness #19887.

@eclipse-che eclipse-che deleted a comment from che-bot Jun 7, 2021
@dmytro-ndp dmytro-ndp merged commit 124235f into main Jun 7, 2021
@dmytro-ndp dmytro-ndp deleted the che-19822 branch June 7, 2021 12:11
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 7, 2021
@che-bot che-bot added this to the 7.32 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katka92 Katka92 Katka92 approved these changes

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@artaleks9 artaleks9 artaleks9 approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim musienko-maxim is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@ScrewTSW ScrewTSW Awaiting requested review from ScrewTSW

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
7.32
Development

Successfully merging this pull request may close these issues.

Happy path tests are failing on "Check the running application" step
5 participants
@dmytro-ndp @che-bot @artaleks9 @Ohrimenko1988 @Katka92