Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide minimal test for Camel on SpringBoot stack #20189

Closed
wants to merge 1 commit into from
Closed

feat: provide minimal test for Camel on SpringBoot stack #20189

wants to merge 1 commit into from

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Jul 23, 2021 •
edited
Loading

  • check start of workspace
  • check Camel and java language server initialized by checking
    completion
  • check build task

What does this PR do?

provide minimal test for Camel on SpringBoot stack

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#14780

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jul 23, 2021
@apupier
Copy link
Contributor Author

apupier commented Jul 23, 2021

unfortunately, for now I wasn't able to play tests (cannot start a local che currently). I was hoping that they will be executed as PR check :-(

@apupier
Copy link
Contributor Author

apupier commented Jul 27, 2021

now able to launch a Che instance locally but cannto play tests succesfully, see https://mattermost.eclipse.org/eclipse/pl/8ia5qys7nfgepr1idif6zssjjy

@che-bot
Copy link
Contributor

che-bot commented Jul 27, 2021

Can one of the admins verify this patch?

@apupier
feat: provide minimal test for Camel on SpringBoot stack
2a64960 
eclipse-che#14780

- check start of workspace
- check Camel and java language server initialized by checking
completion
- check build task

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Jul 28, 2021

made progress yesterday thanks to kfoniok on Che mattermost (and updated PR) But this morning I have this error:

ErrImagePull

Failed to run the workspace: "Plugins installation process failed. Error: Unrecoverable event occurred: 'Failed', 'Error: ErrImagePull', 'workspacecynta8g9mzuxdxz9.che-plugin-broker'"

@ScrewTSW
Copy link
Member

made progress yesterday thanks to kfoniok on Che mattermost (and updated PR) But this morning I have this error:

ErrImagePull

Failed to run the workspace: "Plugins installation process failed. Error: Unrecoverable event occurred: 'Failed', 'Error: ErrImagePull', 'workspacecynta8g9mzuxdxz9.che-plugin-broker'"

Is this still happening?
Do you have an URL to the image in question?
Is it present on quay.io? if not, and required, did you set-up image pulling proxy policy on the cluster?

Sorry for the late reply.

ScrewTSW
ScrewTSW approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case code looks appropriate and perfectly clean :)

@che-bot
Copy link
Contributor

che-bot commented May 28, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 28, 2022
@che-bot che-bot closed this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScrewTSW ScrewTSW ScrewTSW approved these changes

@Katka92 Katka92 Awaiting requested review from Katka92

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim musienko-maxim is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apupier @che-bot @ScrewTSW