Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for debug configuration #20349

Merged

Conversation

ScrewTSW
Copy link
Member

Signed-off-by: Tibor Dancs tdancs@redhat.com

What does this PR do?

  • Added retry and run debug again if the configuration is missing

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

#19887

How to test this PR?

  • Go into Eclipse repository che/tests/e2e
  • Run npm i and verify that all packages install without errors
  • Run tsc and verify that no errors are present
  • Export following variables:
    • TS_SELENIUM_BASE_URL
    • TS_SELENIUM_MULTIUSER=true
    • NODE_TLS_REJECT_UNAUTHORIZED=0
    • TS_SELENIUM_LOG_LEVEL="TRACE"
    • TS_SELENIUM_USERNAME
    • TS_SELENIUM_PASSWORD
  • Run npm run test-java-vertx to execute the smoke test devfile and verify that the tests are working correctly or run entire suite using npm run test-all-devfiles
  • Tests should pass without a failure

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 23, 2021
@ScrewTSW
Copy link
Member Author

[crw-ci-test]

@ScrewTSW ScrewTSW merged commit d20908c into 7.34.x Aug 24, 2021
@ScrewTSW ScrewTSW deleted the 19887-fix-missing-debug-configuration-for-che-7.34.x branch August 24, 2021 08:53
@che-bot che-bot added this to the 7.34 milestone Aug 24, 2021
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 24, 2021
ScrewTSW added a commit to ScrewTSW/che that referenced this pull request Sep 13, 2021
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants