Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize DevWorkspace Happy Path test scripts #20601

Merged
merged 24 commits into from
Oct 11, 2021
Merged

Centralize DevWorkspace Happy Path test scripts #20601

merged 24 commits into from
Oct 11, 2021

Conversation

musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Oct 6, 2021

What does this PR do?

This PR apply using scripts for launching DevWorkspace Happy Path from one place for avoiding duplicate some minor fix/changes in other projects which use similar parts of a script.
More details in the related issue: #20421

DevWorkspace Operator PR check is adapted in devfile/devworkspace-operator#641
TODO

  • adapt Che Dashboard PR check
  • adapt Che Operator PR check

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#20421

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Oct 6, 2021
@che-bot
Copy link
Contributor

che-bot commented Oct 6, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sparkoo sparkoo removed their request for review October 10, 2021 19:04
@sleshchenko sleshchenko self-requested a review October 11, 2021 08:04
.oci/devworkspace-happy-path-test.sh Outdated Show resolved Hide resolved
tests/scripts/che-devworkspace-happy-path.sh Outdated Show resolved Hide resolved
tests/scripts/resources/fake-dwo-csv.yaml Outdated Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Oct 11, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko sleshchenko merged commit 669ee60 into main Oct 11, 2021
@sleshchenko sleshchenko deleted the CHE-20421 branch October 11, 2021 13:04
@sleshchenko
Copy link
Member

Merged since the flow is working.
Minor improvements should be provided separately if any ideas appear

@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 11, 2021
@che-bot che-bot added this to the 7.38 milestone Oct 11, 2021
@che-bot
Copy link
Contributor

che-bot commented Oct 11, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants