che-1865: Fix disable compare button in the compare widget when we have changed few files #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/53/ |
|
Ok to me |
|
@azatsarynnyy @sleshchenko review please |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/58/ |
|
ok |
| @@ -68,9 +68,9 @@ public void show(Map<String, Status> changedFiles, String revision, Project proj | |||
| this.changedFiles = changedFiles; | |||
| this.project = project; | |||
| view.showDialog(); | |||
| view.setEnableCompareButton(false); | |||
There was a problem hiding this comment.
mb it would be better to init state of view and only then show dialog?
AndrienkoAleksandr
force-pushed
the
che-1865
branch
from
7009f32 to
49ddeed
Compare
|
OK |
… window. Fix disabled state of the compare button when we open Git compare window and it contains some changed files to compare. Delete unused code. Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
che-1865
branch
from
49ddeed to
1adc400
Compare
|
+0 |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/82/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
che-1865: Fix disable compare button in the compare widget when we have changed few files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix disable compare button when we have changed few files and open compare widget. By default tree with changes select first element and compare button should be enabled.
What issues does this PR fix or reference?
#1865
Tests written?
No
Docs requirements?
Include the content for all the docs changes required.
@vinokurig review please
Signed-off-by: Aleksandr Andrienko aandrienko@codenvy.com