Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced npm install with npm ci appropriately #20927

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

makambalaji
Copy link
Contributor

@makambalaji makambalaji commented Dec 14, 2021

What does this PR do?

Replaced the npm install command with npm ci command at all respective places.

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

How to test this PR?

  • Execute npm ci command for npm dependencies
  • Execute any test case as described in README, scripts should be executed successfully

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Dec 14, 2021
@makambalaji makambalaji marked this pull request as ready for review December 14, 2021 12:08
@che-bot
Copy link
Contributor

che-bot commented Dec 14, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

tests/e2e/README.md Outdated Show resolved Hide resolved
Update tests/e2e/README.md

Co-authored-by: Florent BENOIT <fbenoit@redhat.com>

Removed the change related to nodejs-web-app project
@che-bot
Copy link
Contributor

che-bot commented Dec 14, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@dmytro-ndp
Copy link
Contributor

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Dec 14, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmytro-ndp dmytro-ndp merged commit 7a745f0 into eclipse-che:main Dec 14, 2021
@che-bot che-bot added this to the 7.41 milestone Dec 14, 2021
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants