Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: EmtpyWorkspace test path #21920

Merged
merged 1 commit into from
Jan 6, 2023
Merged

chore: EmtpyWorkspace test path #21920

merged 1 commit into from
Jan 6, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 6, 2023

@tolusha
fix: EmtpyWorkspace test path
13a7af1 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) labels Jan 6, 2023
nickboldt
nickboldt approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious... the file I see in the che repo is:

https://github.com/eclipse/che/blob/main/tests/e2e/tests/devfiles/che-code/EmptyWorkspace.spec.ts (with .ts).

But this changes to refer to .js ... is that intentional?

Does the file get compiled from .ts -> .js?

@tolusha tolusha changed the title fix: EmtpyWorkspace test path chore: EmtpyWorkspace test path Jan 6, 2023
@tolusha
Copy link
Contributor Author

tolusha commented Jan 6, 2023

Exactly, the extension is changed after compilation

@tolusha tolusha merged commit 4b1e81d into main Jan 6, 2023
@tolusha tolusha deleted the 21836_4 branch January 6, 2023 14:45
@dmytro-ndp
Copy link
Contributor

But this changes to refer to .js ... is that intentional?

Yes, because there is no .ts scripts in dist directory, only .js ones.

@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 6, 2023
@che-bot che-bot added this to the 7.60 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim musienko-maxim is a code owner

@ScrewTSW ScrewTSW Awaiting requested review from ScrewTSW

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp dmytro-ndp is a code owner

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
7.60
Development

Successfully merging this pull request may close these issues.
4 participants
@tolusha @dmytro-ndp @nickboldt @che-bot