-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitnami stacks and blank project for use with the generators #2301
Conversation
Can one of the admins verify this patch? |
Thanks for your PR @amrecio ! We will review the stack asap. |
@@ -0,0 +1,177 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
<svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This icon is missing a licence header.
You can give a look at this one:
https://github.com/eclipse/che/blob/master/ide/che-core-ide-stacks/src/main/resources/images/type-che.svg?short_path=2182d77#L2-L13
The stack and sample look good. |
Thanks for your comments! I'll update the icon to fix the issues. |
@ashumilova : I've updated the icon and saved it as "plain SVG". I left the metadata that it left but let me know if I should remove it too. |
@amrecio It's fine, thank you |
@slemeur - as part of this merge, once it is done, can you have James add the appropriate Tutorial pages to the Eclipse Che docs sections for each of these types? Let's have a good summary on the docs page and then a link over to the bitnami pages where the full tutorial is provided. |
yes. and we will be more exhaustive on the components and tags as well. |
this issue should be back ported to https://github.com/eclipse/che/tree/4.7.x branch for release 4.7.1 |
Here is the adaption of current PR to model changes #2345 |
I've updated the PR to add several Bitnami stacks. We're having some issues with Docker Hub and a few images are still queued for building but everything should work once they're ready. |
@amrecio Could you update the PR with the latest changes? |
Yes, sorry. I merged the PR into master instead of the right branch. I'll update it right now. |
I've updated the PR and squashed the commits with the latest changes. |
Thanks a lot ! |
@ashumilova Done! I kept the Bitrock copyright header in the SVG icon but let me know if I should use Codenvy's instead. |
changed milestone to 5.0.0-M1 as we already ship 4.7.2 with those changes. |
@amrecio it's ok, lets keep Bitrock copyright, but for Che to build and pass license check successfully need to add following to che-core-ide-stacks/pom.xml: |
Signed-off-by: Alvaro Manuel Recio Perez <amrecio@gmail.com>
@ashumilova After fixing a wrong rebase on my part, the PR is ready, including your patch to |
Thank you! Merged. |
Add Bitnami stacks and blank project for use with the generators
What does this PR do?
Add several Bitnami Stacks (Express 4.14.0, Swift 3.0-PREVIEW-6, Laravel 5.2.31, Rails 5.0.0.1, CodeIgniter 3.1.0, Symfony 3.1.3, and Play 2.55), and a "blank" sample application intended to be populated by the generators, which can be run as a Che command.
What issues does this PR fix or reference?
It doesn't reference an issue.
New behavior
Express stack added to Stack Library. Express sample added to samples.
PR type
Minor change checklist
Major change checklist
Signed-off-by: Alvaro Manuel Recio Perez amrecio@gmail.com