Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitnami stacks and blank project for use with the generators #2301

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Add Bitnami stacks and blank project for use with the generators #2301

merged 1 commit into from
Sep 13, 2016

Conversation

amrecio
Copy link
Contributor

@amrecio amrecio commented Sep 1, 2016

What does this PR do?

Add several Bitnami Stacks (Express 4.14.0, Swift 3.0-PREVIEW-6, Laravel 5.2.31, Rails 5.0.0.1, CodeIgniter 3.1.0, Symfony 3.1.3, and Play 2.55), and a "blank" sample application intended to be populated by the generators, which can be run as a Che command.

What issues does this PR fix or reference?

It doesn't reference an issue.

New behavior

Express stack added to Stack Library. Express sample added to samples.

PR type

  • Minor change = no change to existing features or docs
  • Major change = changes existing features or docs

Minor change checklist

  • New API required?
  • API updated
  • Tests provided / updated
  • Tests passed

Major change checklist

  • New API required?
  • API updated
  • Documentation provided (include here or link to docs)
  • Tests provided / updated
  • Tests passed

Signed-off-by: Alvaro Manuel Recio Perez amrecio@gmail.com

@amrecio amrecio changed the title Add Express 4.13.4 stack and blank project for generator Add Bitnami Express 4.13.4 stack and blank project for use with express-generator Sep 1, 2016
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@slemeur
Copy link
Contributor

slemeur commented Sep 1, 2016

Thanks for your PR @amrecio ! We will review the stack asap.
@ashumilova + @eivantsov : could you please give a look?

@@ -0,0 +1,177 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashumilova
Copy link
Contributor

The stack and sample look good.
About icon - in Inkskape it can be saved as plain or optimized SVG to avoid unnecessary inkscape tags and metadata.

@amrecio
Copy link
Contributor Author

amrecio commented Sep 1, 2016

Thanks for your comments! I'll update the icon to fix the issues.

@amrecio
Copy link
Contributor Author

amrecio commented Sep 1, 2016

@ashumilova : I've updated the icon and saved it as "plain SVG". I left the metadata that it left but let me know if I should remove it too.

@ashumilova
Copy link
Contributor

@amrecio It's fine, thank you

@slemeur slemeur added this to the 4.7.1 milestone Sep 5, 2016
@slemeur slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 5, 2016
@TylerJewell
Copy link

@slemeur - as part of this merge, once it is done, can you have James add the appropriate Tutorial pages to the Eclipse Che docs sections for each of these types? Let's have a good summary on the docs page and then a link over to the bitnami pages where the full tutorial is provided.

@slemeur
Copy link
Contributor

slemeur commented Sep 5, 2016

yes. and we will be more exhaustive on the components and tags as well.

@riuvshin
Copy link
Contributor

riuvshin commented Sep 5, 2016

this issue should be back ported to https://github.com/eclipse/che/tree/4.7.x branch for release 4.7.1
Please note that in current master model is different from one we have in 4.7.x so It may require to different PRs

@ashumilova
Copy link
Contributor

Here is the adaption of current PR to model changes #2345

@bmicklea bmicklea mentioned this pull request Sep 6, 2016
25 tasks
@slemeur slemeur modified the milestones: 4.7.2, 4.7.1 Sep 7, 2016
@riuvshin riuvshin modified the milestones: 4.7.2, 4.7.1 Sep 7, 2016
@amrecio amrecio changed the title Add Bitnami Express 4.13.4 stack and blank project for use with express-generator Add Bitnami stacks and blank project for use with the generators Sep 7, 2016
@amrecio
Copy link
Contributor Author

amrecio commented Sep 7, 2016

I've updated the PR to add several Bitnami stacks. We're having some issues with Docker Hub and a few images are still queued for building but everything should work once they're ready.

@slemeur
Copy link
Contributor

slemeur commented Sep 8, 2016

@amrecio Could you update the PR with the latest changes?

@amrecio
Copy link
Contributor Author

amrecio commented Sep 8, 2016

Yes, sorry. I merged the PR into master instead of the right branch. I'll update it right now.

@amrecio
Copy link
Contributor Author

amrecio commented Sep 8, 2016

I've updated the PR and squashed the commits with the latest changes.

@slemeur
Copy link
Contributor

slemeur commented Sep 8, 2016

Thanks a lot !

@ashumilova
Copy link
Contributor

ashumilova commented Sep 9, 2016

@amrecio can you please update current PR with following changes #2397 - fixed only the model changes. And we will merge to master.
My PR fails with ip-validation

@amrecio
Copy link
Contributor Author

amrecio commented Sep 9, 2016

@ashumilova Done! I kept the Bitrock copyright header in the SVG icon but let me know if I should use Codenvy's instead.

@riuvshin riuvshin modified the milestones: 5.0.0-M1, 4.7.1 Sep 9, 2016
@riuvshin
Copy link
Contributor

riuvshin commented Sep 9, 2016

changed milestone to 5.0.0-M1 as we already ship 4.7.2 with those changes.

@bmicklea bmicklea mentioned this pull request Sep 9, 2016
14 tasks
@ashumilova
Copy link
Contributor

ashumilova commented Sep 12, 2016

@amrecio it's ok, lets keep Bitrock copyright, but for Che to build and pass license check successfully need to add following to che-core-ide-stacks/pom.xml:
<build>
<plugins>
<plugin>
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
<configuration>
<excludes>
<exclude>**/type-bitnami.svg</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</build>

Signed-off-by: Alvaro Manuel Recio Perez <amrecio@gmail.com>
@amrecio
Copy link
Contributor Author

amrecio commented Sep 13, 2016

@ashumilova After fixing a wrong rebase on my part, the PR is ready, including your patch to che-core-ide-stacks/pom.xml. Please let me know if any other change is needed.

@ashumilova ashumilova merged commit 729ca8a into eclipse-che:master Sep 13, 2016
@ashumilova
Copy link
Contributor

Thank you! Merged.

@amrecio amrecio deleted the express branch September 13, 2016 08:07
@bmicklea bmicklea mentioned this pull request Sep 13, 2016
57 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Add Bitnami stacks and blank project for use with the generators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants