InitializeParams should include an empty ClientCapabilities #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol specifies that the InitializeParams object contains a capabilities property. Eclipse Che does not define it, so there are language servers that fails to initialize because of this. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
|
Can one of the admins verify this patch? |
|
@evidolob @vparfonov - can you please review and approve? Let's target this for M2. |
TylerJewell
added
the
kind/enhancement
|
@tolusha I see the Do I miss anything? Should I open a new PR to master? |
|
@kaloyan-raev Yes pls, make PR to master. |
|
Done - #2466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets client capabilities property in the InitializeParams object.
What issues does this PR fix or reference?
felixfbecker/php-language-server#6 (comment)
PR type
Minor change checklist
The protocol specifies that the InitializeParams object contains a
capabilities property. Eclipse Che does not define it, so there are
language servers that fails to initialize because of this.
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com