Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Rework NodeJS Express devfile API test #23287

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Conversation

SkorikSergey
Copy link
Contributor

@SkorikSergey SkorikSergey commented Dec 16, 2024

What does this PR do?

Rework the NodeJS Express devfile API test regarding our previous strategy wich was implemented in the PHP devfile API test

Screenshot/screencast of this PR

  NodeJS Express devfile API test
          ▼ KubernetesCommandLineToolsExecutor.loginToOcp - oc - login to the "OC" client.
          ▼ KubernetesCommandLineToolsExecutor.getServerUrl - oc - get server api url.
          ▼ KubernetesCommandLineToolsExecutor.isUserLoggedIn - oc
          ▼ ShellExecutor.executeCommand - oc whoami && oc whoami --show-server=true
admin
https://api.ocp417-sskoryk.crw-qe.com:6443
          ▼ KubernetesCommandLineToolsExecutor.getServerUrl - oc - get server api url.
          ▼ KubernetesCommandLineToolsExecutor.loginToOcp - oc - user already logged
command: oc get pods -n openshift-devspaces
          ▼ ShellExecutor.executeArbitraryShellScript - oc get pods -n openshift-devspaces | grep dashboard | awk '{print $1}'
          ▼ ShellExecutor.executeCommand - oc get pods -n openshift-devspaces | grep dashboard | awk '{print $1}'
devspaces-dashboard-5c99658d6f-s4qzc
          ▼ ShellExecutor.executeArbitraryShellScript - oc get pod -n openshift-devspaces devspaces-dashboard-5c99658d6f-s4qzc -o jsonpath='{.spec.containers[*].name}'
          ▼ ShellExecutor.executeCommand - oc get pod -n openshift-devspaces devspaces-dashboard-5c99658d6f-s4qzc -o jsonpath='{.spec.containers[*].name}'
devspaces-dashboard          ▼ ShellExecutor.executeArbitraryShellScript - oc get svc devspaces-dashboard -n  openshift-devspaces -o=jsonpath='{.spec.clusterIP}'
          ▼ ShellExecutor.executeCommand - oc get svc devspaces-dashboard -n  openshift-devspaces -o=jsonpath='{.spec.clusterIP}'
172.30.196.96          ▼ ShellExecutor.executeArbitraryShellScript - oc get svc devspaces-dashboard -n  openshift-devspaces -o=jsonpath='{.spec.ports[*].port}'
          ▼ ShellExecutor.executeCommand - oc get svc devspaces-dashboard -n  openshift-devspaces -o=jsonpath='{.spec.ports[*].port}'
8080          ▼ ShellExecutor.executeCommand - oc exec -i devspaces-dashboard-5c99658d6f-s4qzc -n  openshift-devspaces -c devspaces-dashboard -- sh -c 'curl -o /tmp/nodejs-express-devfile.yaml http://172.30.196.96:8080/dashboard/api/airgap-sample/devfile/download?id=nodejs-express'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2065  100  2065    0     0  1008k      0 --:--:-- --:--:-- --:--:-- 1008k
          ▼ ShellExecutor.executeArbitraryShellScript - oc exec -i devspaces-dashboard-5c99658d6f-s4qzc -n  openshift-devspaces -c devspaces-dashboard -- cat /tmp/nodejs-express-devfile.yaml
          ▼ ShellExecutor.executeCommand - oc exec -i devspaces-dashboard-5c99658d6f-s4qzc -n  openshift-devspaces -c devspaces-dashboard -- cat /tmp/nodejs-express-devfile.yaml
schemaVersion: 2.2.2
metadata:
  name: nodejs-web-app
components:
  - name: tools
    container:
      image: registry.redhat.io/devspaces/udi-rhel8@sha256:d147892c643a0127cfcf868daee0ff416a8df922fe2a7c716ebfc457ff526fa2
      endpoints:
        - exposure: public
          name: nodejs
          protocol: https
          targetPort: 3000
      memoryLimit: '1Gi'
      memoryRequest: '512Mi'
      cpuLimit: '0.5'
      cpuRequest: '0.25'
      mountSources: true
      volumeMounts:
        - name: npm
          path: /home/user/.npm
  - name: npm
    volume:
      size: 1G
commands:
  - id: 1-dependencies
    exec:
      label: "Download dependencies"
      component: tools
      workingDir: ${PROJECTS_ROOT}/web-nodejs-sample/app
      commandLine: "npm install"
      group:
        kind: build
  - id: 2-run
    exec:
      label: "Run the web app"
      component: tools
      workingDir: ${PROJECTS_ROOT}/web-nodejs-sample/app
      commandLine: "nodemon app.js"
      group:
        kind: run
  - id: 3-install-and-run
    exec:
      label: "Run the web app (and download dependencies)"
      component: tools
      workingDir: ${PROJECTS_ROOT}/web-nodejs-sample/app
      commandLine: "npm install; nodemon app.js"
      group:
        kind: run
  - id: 4-debug
    exec:
      label: "Run the web app (debugging enabled)"
      component: tools
      workingDir: ${PROJECTS_ROOT}/web-nodejs-sample/app
      commandLine: "nodemon --inspect app.js"
      group:
        kind: debug
        isDefault: true
  - id: 5-stopapp
    exec:
      label: "Stop the web app"
      component: tools
      commandLine: >-
        node_server_pids=$(pgrep -fx '.*nodemon (--inspect )?app.js' | tr "\\n" "
        ") && echo "Stopping node server with PIDs: ${node_server_pids}" &&  kill
        -15 ${node_server_pids} &>/dev/null && echo 'Done.'
      group:
        kind: run
projects:
  - name: web-nodejs-sample
    zip:
      location: http://devspaces-dashboard.openshift-devspaces.svc:8080/dashboard/api/airgap-sample/project/download?id=nodejs-express
          ▼ ShellExecutor.executeCommand - oc get configmap editors-definitions -o jsonpath="{.data.che-code\.yaml}" -n openshift-devspaces
commands:
- apply:
    component: che-code-injector
  id: init-container-command
- exec:
    commandLine: nohup /checode/entrypoint-volume.sh > /checode/entrypoint-logs.txt
      2>&1 &
    component: che-code-runtime-description
  id: init-che-code-command
components:
- container:
    command:
    - /entrypoint-init-container.sh
    cpuLimit: 500m
    cpuRequest: 30m
    image: registry.redhat.io/devspaces/code-rhel8@sha256:02c8f907dc2e18c61fa643accbf8378f385d3368af49794a78b9529cc63eb636
    memoryLimit: 256Mi
    memoryRequest: 32Mi
    volumeMounts:
    - name: checode
      path: /checode
  name: che-code-injector
- attributes:
    app.kubernetes.io/component: che-code-runtime
    app.kubernetes.io/part-of: che-code.eclipse.org
    controller.devfile.io/container-contribution: true
  container:
    cpuLimit: 500m
    cpuRequest: 30m
    endpoints:
    - attributes:
        cookiesAuthEnabled: true
        discoverable: false
        type: main
        urlRewriteSupported: true
      exposure: public
      name: che-code
      protocol: https
      secure: true
      targetPort: 3100
    - attributes:
        discoverable: false
        urlRewriteSupported: false
      exposure: public
      name: code-redirect-1
      protocol: https
      targetPort: 13131
    - attributes:
        discoverable: false
        urlRewriteSupported: false
      exposure: public
      name: code-redirect-2
      protocol: https
      targetPort: 13132
    - attributes:
        discoverable: false
        urlRewriteSupported: false
      exposure: public
      name: code-redirect-3
      protocol: https
      targetPort: 13133
    image: registry.redhat.io/devspaces/udi-rhel8@sha256:d147892c643a0127cfcf868daee0ff416a8df922fe2a7c716ebfc457ff526fa2
    memoryLimit: 1024Mi
    memoryRequest: 256Mi
    volumeMounts:
    - name: checode
      path: /checode
  name: che-code-runtime-description
- name: checode
  volume: {}
events:
  postStart:
  - init-che-code-command
  preStart:
  - init-container-command
metadata:
  attributes:
    firstPublicationDate: "2022-07-19"
    iconData: |
      <svg width="100" height="100" viewBox="0 0 100 100" fill="none" xmlns="http://www.w3.org/2000/svg">
      <mask id="mask0" mask-type="alpha" maskUnits="userSpaceOnUse" x="0" y="0" width="100" height="100">
      <path fill-rule="evenodd" clip-rule="evenodd" d="M70.9119 99.3171C72.4869 99.9307 74.2828 99.8914 75.8725 99.1264L96.4608 89.2197C98.6242 88.1787 100 85.9892 100 83.5872V16.4133C100 14.0113 98.6243 11.8218 96.4609 10.7808L75.8725 0.873756C73.7862 -0.130129 71.3446 0.11576 69.5135 1.44695C69.252 1.63711 69.0028 1.84943 68.769 2.08341L29.3551 38.0415L12.1872 25.0096C10.589 23.7965 8.35363 23.8959 6.86933 25.2461L1.36303 30.2549C-0.452552 31.9064 -0.454633 34.7627 1.35853 36.417L16.2471 50.0001L1.35853 63.5832C-0.454633 65.2374 -0.452552 68.0938 1.36303 69.7453L6.86933 74.7541C8.35363 76.1043 10.589 76.2037 12.1872 74.9905L29.3551 61.9587L68.769 97.9167C69.3925 98.5406 70.1246 99.0104 70.9119 99.3171ZM75.0152 27.2989L45.1091 50.0001L75.0152 72.7012V27.2989Z" fill="white"/>
      </mask>
      <g mask="url(#mask0)">
      <path d="M96.4614 10.7962L75.8569 0.875542C73.4719 -0.272773 70.6217 0.211611 68.75 2.08333L1.29858 63.5832C-0.515693 65.2373 -0.513607 68.0937 1.30308 69.7452L6.81272 74.754C8.29793 76.1042 10.5347 76.2036 12.1338 74.9905L93.3609 13.3699C96.086 11.3026 100 13.2462 100 16.6667V16.4275C100 14.0265 98.6246 11.8378 96.4614 10.7962Z" fill="#0065A9"/>
      <g filter="url(#filter0_d)">
      <path d="M96.4614 89.2038L75.8569 99.1245C73.4719 100.273 70.6217 99.7884 68.75 97.9167L1.29858 36.4169C-0.515693 34.7627 -0.513607 31.9063 1.30308 30.2548L6.81272 25.246C8.29793 23.8958 10.5347 23.7964 12.1338 25.0095L93.3609 86.6301C96.086 88.6974 100 86.7538 100 83.3334V83.5726C100 85.9735 98.6246 88.1622 96.4614 89.2038Z" fill="#007ACC"/>
      </g>
      <g filter="url(#filter1_d)">
      <path d="M75.8578 99.1263C73.4721 100.274 70.6219 99.7885 68.75 97.9166C71.0564 100.223 75 98.5895 75 95.3278V4.67213C75 1.41039 71.0564 -0.223106 68.75 2.08329C70.6219 0.211402 73.4721 -0.273666 75.8578 0.873633L96.4587 10.7807C98.6234 11.8217 100 14.0112 100 16.4132V83.5871C100 85.9891 98.6234 88.1786 96.4586 89.2196L75.8578 99.1263Z" fill="#1F9CF0"/>
      </g>
      <g style="mix-blend-mode:overlay" opacity="0.25">
      <path fill-rule="evenodd" clip-rule="evenodd" d="M70.8511 99.3171C72.4261 99.9306 74.2221 99.8913 75.8117 99.1264L96.4 89.2197C98.5634 88.1787 99.9392 85.9892 99.9392 83.5871V16.4133C99.9392 14.0112 98.5635 11.8217 96.4001 10.7807L75.8117 0.873695C73.7255 -0.13019 71.2838 0.115699 69.4527 1.44688C69.1912 1.63705 68.942 1.84937 68.7082 2.08335L29.2943 38.0414L12.1264 25.0096C10.5283 23.7964 8.29285 23.8959 6.80855 25.246L1.30225 30.2548C-0.513334 31.9064 -0.515415 34.7627 1.29775 36.4169L16.1863 50L1.29775 63.5832C-0.515415 65.2374 -0.513334 68.0937 1.30225 69.7452L6.80855 74.754C8.29285 76.1042 10.5283 76.2036 12.1264 74.9905L29.2943 61.9586L68.7082 97.9167C69.3317 98.5405 70.0638 99.0104 70.8511 99.3171ZM74.9544 27.2989L45.0483 50L74.9544 72.7012V27.2989Z" fill="url(#paint0_linear)"/>
      </g>
      </g>
      <defs>
      <filter id="filter0_d" x="-8.39411" y="15.8291" width="116.727" height="92.2456" filterUnits="userSpaceOnUse" color-interpolation-filters="sRGB">
      <feFlood flood-opacity="0" result="BackgroundImageFix"/>
      <feColorMatrix in="SourceAlpha" type="matrix" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 127 0"/>
      <feOffset/>
      <feGaussianBlur stdDeviation="4.16667"/>
      <feColorMatrix type="matrix" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.25 0"/>
      <feBlend mode="overlay" in2="BackgroundImageFix" result="effect1_dropShadow"/>
      <feBlend mode="normal" in="SourceGraphic" in2="effect1_dropShadow" result="shape"/>
      </filter>
      <filter id="filter1_d" x="60.4167" y="-8.07558" width="47.9167" height="116.151" filterUnits="userSpaceOnUse" color-interpolation-filters="sRGB">
      <feFlood flood-opacity="0" result="BackgroundImageFix"/>
      <feColorMatrix in="SourceAlpha" type="matrix" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 127 0"/>
      <feOffset/>
      <feGaussianBlur stdDeviation="4.16667"/>
      <feColorMatrix type="matrix" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.25 0"/>
      <feBlend mode="overlay" in2="BackgroundImageFix" result="effect1_dropShadow"/>
      <feBlend mode="normal" in="SourceGraphic" in2="effect1_dropShadow" result="shape"/>
      </filter>
      <linearGradient id="paint0_linear" x1="49.9392" y1="0.257812" x2="49.9392" y2="99.7423" gradientUnits="userSpaceOnUse">
      <stop stop-color="white"/>
      <stop offset="1" stop-color="white" stop-opacity="0"/>
      </linearGradient>
      </defs>
      </svg>
    iconMediatype: image/svg+xml
    publisher: che-incubator
    repository: https://github.com/che-incubator/che-code
    skipMetaYaml: true
    title: Red Hat OpenShift Dev Spaces with Microsoft Visual Studio Code - Open Source
      IDE
    version: latest
  description: Red Hat OpenShift Dev Spaces with Microsoft Visual Studio Code - Open
    Source IDE
  displayName: VS Code - Open Source
  name: che-code
schemaVersion: 2.2.2
          ▼ DevWorkspaceConfigurationHelper.generateDevfileContext
No plug-in registry url. Setting to https://eclipse-che.github.io/che-plugin-registry/main/v3
Validating devfile
Devfile is valid with schema version 2.2.2
DevWorkspace che-code-nodejs-web-app was generated
          ▼ DevWorkspaceConfigurationHelper.getDevWorkspaceConfigurationYamlAsString
          ▼ KubernetesCommandLineToolsExecutor.applyAndWaitDevWorkspace - oc
          ▼ KubernetesCommandLineToolsExecutor.applyYamlConfigurationAsStringOutput - oc
          ▼ ShellExecutor.executeCommand - oc apply -n admin-devspaces -f /tmp/devfile-9874.yaml && rm -f /tmp/devfile-9874.yaml
devworkspacetemplate.workspace.devfile.io/che-code-nodejs-web-app created
devworkspace.workspace.devfile.io/nodejs-web-app07f26267 created
          ▼ KubernetesCommandLineToolsExecutor.waitDevWorkspace - oc - wait till workspace ready.
          ▼ ShellExecutor.executeCommand - oc wait -n admin-devspaces --for=condition=Ready dw nodejs-web-app07f26267 --timeout=360s
devworkspace.workspace.devfile.io/nodejs-web-app07f26267 condition met
          ▼ KubernetesCommandLineToolsExecutor.getPodAndContainerNames - oc
          ▼ KubernetesCommandLineToolsExecutor.getWorkspacePodName - oc - get workspace pod name.
          ▼ ShellExecutor.executeCommand - oc get pod -l controller.devfile.io/devworkspace_name=nodejs-web-app07f26267 -n admin-devspaces -o name
pod/workspaceb135e57619eb4088-6fd98cf9f-4slms
          ▼ KubernetesCommandLineToolsExecutor.getContainerName - oc - get container name.
          ▼ ShellExecutor.executeCommand - oc get pod/workspaceb135e57619eb4088-6fd98cf9f-4slms -o jsonpath='{.spec.containers[*].name}' -n admin-devspaces
tools che-gateway

    ✔ Create nodejs-express workspace (54556ms)
      • workdir from exec section of DevWorkspace file: ${PROJECTS_ROOT}/web-nodejs-sample/app
      • commandLine from exec section of DevWorkspace file: npm install
          ▼ ContainerTerminal.execInContainerCommand - oc
          ▼ ShellExecutor.executeCommand - oc exec -i -t pod/workspaceb135e57619eb4088-6fd98cf9f-4slms -n admin-devspaces -c tools -- sh -c 'cd ${PROJECTS_ROOT}/web-nodejs-sample/app && npm install'
Unable to use a TTY - input is not a terminal or the right kind of file
npm warn old lockfile
npm warn old lockfile The package-lock.json file was created with an old version of npm,
npm warn old lockfile so supplemental metadata must be fetched from the registry.
npm warn old lockfile
npm warn old lockfile This is a one-time fix-up, please be patient...
npm warn old lockfile

added 50 packages, and audited 51 packages in 2s

7 vulnerabilities (3 low, 4 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
npm notice
npm notice New major version of npm available! 10.8.1 -> 11.0.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.0.0
npm notice To update run: npm install -g npm@11.0.0
npm notice
    ✔ Check packaging application
      • workdir from exec section of DevWorkspace file: ${PROJECTS_ROOT}/web-nodejs-sample/app
      • commandLine from exec section of DevWorkspace file: nodemon app.js
          ▼ ContainerTerminal.execInContainerCommandWithTimeout - oc
          ▼ ShellExecutor.executeCommand -  timeout 20 oc exec -i pod/workspaceb135e57619eb4088-6fd98cf9f-4slms -n admin-devspaces -c tools -- sh -c 'cd ${PROJECTS_ROOT}/web-nodejs-sample/app && nodemon app.js'
[nodemon] 3.0.1
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: js,mjs,cjs,json
[nodemon] starting `node app.js`
Example app listening on port 3000!
    ✔ Check "run the web app" command
      • workdir from exec section of DevWorkspace file: undefined
      • commandLine from exec section of DevWorkspace file: node_server_pids=$(pgrep -fx '.*nodemon (--inspect )?app.js' | tr "\\n" " ") && echo "Stopping node server with PIDs: ${node_server_pids}" &&  kill -15 ${node_server_pids} &>/dev/null && echo 'Done.'
          ▼ ContainerTerminal.execInContainerCommand - oc
          ▼ ShellExecutor.executeCommand - oc exec -i -t pod/workspaceb135e57619eb4088-6fd98cf9f-4slms -n admin-devspaces -c tools -- sh -c 'node_server_pids=$(pgrep -fx '"'"'.*nodemon (--inspect )?app.js'"'"' | tr "\\n" " ") && echo "Stopping node server with PIDs: ${node_server_pids}" &&  kill -15 ${node_server_pids} &>/dev/null && echo '"'"'Done.'"'"''
Unable to use a TTY - input is not a terminal or the right kind of file
Stopping node server with PIDs: 92 
Done.
    ✔ Check "stop the web app" command
      • workdir from exec section of DevWorkspace file: ${PROJECTS_ROOT}/web-nodejs-sample/app
      • commandLine from exec section of DevWorkspace file: nodemon --inspect app.js
          ▼ ContainerTerminal.execInContainerCommandWithTimeout - oc
          ▼ ShellExecutor.executeCommand -  timeout 20 oc exec -i pod/workspaceb135e57619eb4088-6fd98cf9f-4slms -n admin-devspaces -c tools -- sh -c 'cd ${PROJECTS_ROOT}/web-nodejs-sample/app && nodemon --inspect app.js'
Debugger listening on ws://127.0.0.1:9229/fedb093f-2008-402a-8713-197142d40092
For help, see: https://nodejs.org/en/docs/inspector
[nodemon] 3.0.1
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: js,mjs,cjs,json
[nodemon] starting `node --inspect app.js`
Example app listening on port 3000!
    ✔ Check "Run the web app (debugging enabled)" command
          ▼ KubernetesCommandLineToolsExecutor.deleteDevWorkspace - oc - delete 'nodejs-web-app07f26267' devWorkspace
          ▼ ShellExecutor.executeCommand - oc patch dw nodejs-web-app07f26267 -n admin-devspaces -p '{ "metadata": { "finalizers": null }}' --type merge || true
devworkspace.workspace.devfile.io/nodejs-web-app07f26267 patched
          ▼ ShellExecutor.executeCommand - oc delete dw nodejs-web-app07f26267 -n admin-devspaces || true
devworkspace.workspace.devfile.io "nodejs-web-app07f26267" deleted
          ▼ KubernetesCommandLineToolsExecutor.deleteDevWorkspace - oc - delete 'che-code-nodejs-web-app' devWorkspaceTemplate
          ▼ ShellExecutor.executeCommand - oc delete dwt che-code-nodejs-web-app -n admin-devspaces || true
devworkspacetemplate.workspace.devfile.io "che-code-nodejs-web-app" deleted


  5 passing (2m)

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7607

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. area/qe labels Dec 16, 2024
@SkorikSergey SkorikSergey self-assigned this Dec 16, 2024
@SkorikSergey SkorikSergey marked this pull request as ready for review January 7, 2025 14:14
@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jan 7, 2025
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Jan 7, 2025

@SkorikSergey : even though test has passed, I had noticed next error messages in the test logs:

 tr: missing operand after ‘\\n’
 Two strings must be given when translating.
 Try 'tr --help' for more information.
 /bin/sh: 154:  : not found
 tr: missing operand
 Try 'tr --help' for more information.
 /bin/sh: 226: "\\n": not found
 devworkspacetemplate.workspace.devfile.io/che-code-nodejs-web-app created
 devworkspace.workspace.devfile.io/nodejs-web-app96582dc0 created
           ▼ KubernetesCommandLineToolsExecutor.waitDevWorkspace - oc - wait till workspace ready.

Could you take a look, please?

@SkorikSergey
Copy link
Contributor Author

@SkorikSergey : even though test has passed, I had noticed next error messages in the test logs:

 tr: missing operand after ‘\\n’
 Two strings must be given when translating.
 Try 'tr --help' for more information.
 /bin/sh: 154:  : not found
 tr: missing operand
 Try 'tr --help' for more information.
 /bin/sh: 226: "\\n": not found
 devworkspacetemplate.workspace.devfile.io/che-code-nodejs-web-app created
 devworkspace.workspace.devfile.io/nodejs-web-app96582dc0 created
           ▼ KubernetesCommandLineToolsExecutor.waitDevWorkspace - oc - wait till workspace ready.

Could you take a look, please?

This happens on oc apply step

`${this.kubernetesCommandLineTool} exec -i ${KubernetesCommandLineToolsExecutor.pod} -n ${this.namespace} -c ${container} -- sh -c '${commandToExecute}'`

I think that because of 'stop app' command format. It uses single quotes in command line

                  exec:
                    label: Stop the web app
                    component: tools
                    commandLine: "node_server_pids=$(pgrep -fx '.*nodemon (--inspect )?app.js' | tr
                      \"\\\\n\" \" \") && echo \"Stopping node server with PIDs:
                      ${node_server_pids}\" &&  kill -15 ${node_server_pids} &>/dev/null
                      && echo 'Done.'"
                    group:
                      kind: run```

@dmytro-ndp
Copy link
Contributor

@SkorikSergey : thank you for the answer.

In that case we could look for another way to create workspace, apart from cat <<EOF | oc apply -n admin-devspaces -f - command.

@dmytro-ndp
Copy link
Contributor

@SkorikSergey : I have reworked method KubernetesCommandLineToolsExecutor.applyYamlConfigurationAsStringOutput(), in the recent commit, which should fix the errors of workspace creation which was mentioned above.

Could you get the changes from the main branch and run the test again, please?

@SkorikSergey
Copy link
Contributor Author

@SkorikSergey : I have reworked method KubernetesCommandLineToolsExecutor.applyYamlConfigurationAsStringOutput(), in the recent commit, which should fix the errors of workspace creation which was mentioned above.

Could you get the changes from the main branch and run the test again, please?

Works well, thank you

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing review notices, @SkorikSergey !

NodeJsExpressDevFileAPI test passed being run against DS 3.17.0, and error lo didn't contain error messages: https://jenkins-csb-crwqe-main.dno.corp.redhat.com/job/Testing/job/e2e/job/basic/job/api-tests/10778/consoleFull

Well done!

@SkorikSergey SkorikSergey merged commit 2f9d491 into main Jan 9, 2025
5 checks passed
@SkorikSergey SkorikSergey deleted the nodejsexpress branch January 9, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants