-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Rework NodeJS Express devfile API test #23287
Conversation
f96c1f3
to
a7f3c37
Compare
@SkorikSergey : even though test has passed, I had noticed next error messages in the test logs:
Could you take a look, please? |
This happens on oc apply step
I think that because of 'stop app' command format. It uses single quotes in command line
|
@SkorikSergey : thank you for the answer. In that case we could look for another way to create workspace, apart from |
@SkorikSergey : I have reworked method Could you get the changes from the |
f7ade6f
to
de90f4b
Compare
Works well, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing review notices, @SkorikSergey !
NodeJsExpressDevFileAPI test passed being run against DS 3.17.0, and error lo didn't contain error messages: https://jenkins-csb-crwqe-main.dno.corp.redhat.com/job/Testing/job/e2e/job/basic/job/api-tests/10778/consoleFull
Well done!
What does this PR do?
Rework the NodeJS Express devfile API test regarding our previous strategy wich was implemented in the PHP devfile API test
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7607
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.