Fix #2471: Send json/schemaAssociations notification #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJewell
added
the
kind/enhancement
|
Can one of the admins verify this patch? |
26 tasks
This was referenced Sep 26, 2016
Closed
kaloyan-raev
force-pushed
the
json-schema-associations
branch
from
8c2cbcc to
fbdc363
Compare
|
I rebased the PR to latest master. |
|
@vparfonov who needs to code review this PR? |
|
@kaloyan-raev can you resolve conflict, please ? |
|
@vparfonov Sure. I think this conflict is due to the big refactoring #2677 merged a few hours ago. |
|
@kaloyan-raev I'm moving this to M6 milestone because we're pushing to get M5 out ASAP. |
The VS Code's JSON language server expects a 'json/schemaAssociations' notification to associate JSON files to JSON schemas. This activates capabilities like code completion, validation and hover without the need to add a '$schema' key. This change implements an extension of the JsonBasedLanguageServer that registers as ServerInitializerObserver and sends the 'json/schemaAssociations' notification on the 'onServerInitialized' event. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
kaloyan-raev
force-pushed
the
json-schema-associations
branch
from
fbdc363 to
6c9ccdf
Compare
|
@vparfonov I rebased the PR to latest master. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…pse-che#2474) The VS Code's JSON language server expects a 'json/schemaAssociations' notification to associate JSON files to JSON schemas. This activates capabilities like code completion, validation and hover without the need to add a '$schema' key. This change implements an extension of the JsonBasedLanguageServer that registers as ServerInitializerObserver and sends the 'json/schemaAssociations' notification on the 'onServerInitialized' event. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The VS Code's JSON language server expects a
json/schemaAssociationsnotification to associate JSON files to JSON schemas. This activates
capabilities like code completion, validation and hover without the need
to add a
$schemakey.This change implements an extension of the JsonBasedLanguageServer that
registers as ServerInitializerObserver and sends the
json/schemaAssociationsnotification on theonServerInitializedevent.
What issues does this PR fix or reference?
#2471, #1287
Previous behavior
Code completion, validation and hover capabilities in the JSON editor were enabled only after manually adding a
$schemakey.New behavior
The JSON editor automatically associates JSON schema for popular JSON files like
package.json,bower.json,composer.json,tsconfig.json, etc. Code completion, validation, hover and other capabilities work out of the box.PR type
Minor change checklist
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com