CHE-2478: add editing mode in workspace view #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build # 466 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/466/ to view the results. |
olexii4
approved these changes
Sep 22, 2016
| @@ -40,7 +40,7 @@ export class WorkspaceEnvironments { | |||
|
|
|||
| this.scope = { | |||
| environmentName: '=', | |||
| environmentViewStatus: '=', | |||
| machinesViewStatus: '=', | |||
There was a problem hiding this comment.
It could be better to use machinesViewStatus: '=cheMachinesViewStatus'. WDYT?
There was a problem hiding this comment.
I don't think so. I think that prefixes are needed for our customized stuff to distinguish from standard/third-party ones.
There was a problem hiding this comment.
+1 on machinesViewStatus
4 tasks
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
benoitf
approved these changes
Sep 28, 2016
|
Need to attach an animated gif with those UI changes |
|
@slemeur animated gif is added into PR description. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/540/ |
ashumilova
approved these changes
Sep 28, 2016
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
CHE-2478: add editing mode in workspace view
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
CHE-2478: add editing mode in workspace view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds an editing mode in workspace view with proposal to save or cancel changes and restart the workspace.
What issues does this PR fix or reference?
#2478
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com