CHE-1769: make workspace creation and edit screen identical. #2706
Conversation
|
Let's discuss that this afternoon @akurinnoy .
|
|
Build # 624 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/624/ to view the results. |
| this.newEnvironmentName = this.environmentName; | ||
| this.environment = this.workspaceConfig.environments[this.environmentName]; | ||
|
|
||
| if (!this.environment.recipe) { | ||
| return; |
There was a problem hiding this comment.
We could add an error message and move up peas of code with machines. WDYT?
There was a problem hiding this comment.
This is about stack's selector initialization. I will move this check into suitable place.
| 'use strict'; | ||
| import {CheWorkspace} from '../../../../components/api/che-workspace.factory'; | ||
| import {ComposeEnvironmentManager} from '../../../../components/api/environment/compose-environment-manager'; | ||
| import {CheEnvironmentRegistry} from '../../../../components/api/environment/che-environment-registry.factory'; |
There was a problem hiding this comment.
I didn't see a benefit of using these types, because we add many path's dependencies in many places. WDYT?
There was a problem hiding this comment.
@olexii4 I don't see the issue of typing with correct type ?
There was a problem hiding this comment.
@benoitf I guess we could try to add a che namespace. I think about it. Not in this issue, but I want try to do it. WDYT?
There was a problem hiding this comment.
@olexii4 I'm ok with both solutions. namespace will take some time to be added while specific import is immediate.
ashumilova
added
the
status/in-progress
|
Build # 647 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/647/ to view the results. |
|
Build # 650 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/650/ to view the results. |
|
Build # 703 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/703/ to view the results. |
|
Build # 718 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/718/ to view the results. |
akurinnoy
changed the title
|
Ok for me. |
| machinesViewStatus: '=', | ||
| workspaceConfig: '=', | ||
| environmentOnChange: '&' | ||
| }; |
There was a problem hiding this comment.
you may add the type for these variables
| this.workspaceKey = this.namespace + ":" + this.workspaceName; | ||
| this.editMode = false; | ||
| this.showApplyMessage = false; | ||
| this.Tab = Tab; |
There was a problem hiding this comment.
we have uppercase variable ?
There was a problem hiding this comment.
It was just typo, fixed
|
Build # 725 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/725/ to view the results. |
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
akurinnoy
removed
the
status/in-progress
|
Build # 727 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/727/ to view the results. |
CHE-1769: make workspace creation and edit screen identical.
What does this PR do?
It makes workspace creation and edit screen identical.
What issues does this PR fix or reference?
#1769
Minor change checklist
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com