Adding 'fast' profile for building Che faster by skipping unit tests,…

[ibuziuk]

What does this PR do?

'fast' profile for building Che faster by skipping unit tests, license checks and other enforcement features

What issues does this PR fix or reference?

#2594

New behavior

"mvn clean verify -Pfast" will allow to build che with the following system properties enabled:

    -DskipTests=true
    -Dfindbugs.skip=true
    -Dskip-validate-sources
    -Dmdep.analyze.skip=true
    -Dlicense.skip=true
    -Dgwt.compiler.localWorkers=2 -T 1C

PR type

• Minor change = no change to existing features or docs
• Major change = changes existing features or docs

Minor change checklist

• New API required?
• API updated
• Tests provided / updated
• Tests passed

Major change checklist

• New API required?
• API updated
• Documentation provided (include here or link to docs)
• Tests provided / updated
• Tests passed

Signed-off-by: Ilya Buziuk ibuziuk@redhat.com

[codenvy-ci]

Can one of the admins verify this patch?

[benoitf]

ci-build

[benoitf]

@ibuziuk After some tests of this profile it looks like -Pfast is not disabling the validate source profile

using -Dskip-validate-sources is working but using -Pfast not.

$ mvn -Pfast help:active-profiles |grep validate-sources
 - validate-sources (source: org.eclipse.che.parent:maven-parent-pom:5.0.0-M6-SNAPSHOT)
 - validate-sources (source: org.eclipse.che.parent:maven-parent-pom:5.0.0-M6-SNAPSHOT)
 - validate-sources (source: org.eclipse.che.parent:maven-parent-pom:5.0.0-M6-SNAPSHOT)
...

$ mvn -Pfast -Dskip-validate-sources help:active-profiles |grep validate-sources

[ibuziuk]

@benoitf oh, this is trickier than I expected it to be. Basically, one can not activate a profile when another one is activated (chaining activation is prohibited in maven). skip-validate-sources actually enables another profile - https://github.com/eclipse/che-parent/blob/master/pom.xml#L1651 . So, the only solution for this situation would be activating both profiles via the same property e.g.

<activation>
  <property>
    <name>fast</name>
  </property>
</activation>

I guess, if we change the fast profile's activation^ and add fast property to validate-source profile activation both should be enabled via mvn clean verify -Dfast

[benoitf]

@ibuziuk note that we also have skip-enforce property.
also I'm not sure it's about chained profile but just that property is read and enable the provile before another profile set value to false
I'm then not sure to have fast to disable their activation (because it's disabled profile if property is set)

[ibuziuk]

@benoitf I do believe if we may have smth. like that:

      <profile>
            <id>validate-sources</id>
            <activation>
                <property>
                    <name>!skip-validate-sources</name>
                    <name>fast</name>
                </property>
            </activation>

AFAIK, This will not disable validate-sources profile but rather add one more condition when it should be enabled. Maven<activation> block is a list of 'or' statements and profile will be activated as soon as the first criteria is met

[ibuziuk]

@benoitf sorry I was wrong about 'or' statements, it used to be like that before v3.2.2 but now it is fixed and it is actually the list of 'and' https://issues.apache.org/jira/browse/MNG-4565

[benoitf]

OK

[TylerJewell]

Cool.

[ibuziuk]

Trying to figure out how it is possible to configure 'or' logic. It seems (and I would really like to be wrong here) that that after the "fix" it is not possible to setup "OR" logic for profile activation :/

[ibuziuk]

@benoitf it is not possible to configure IF condition for maven profile activation unless using a copy-paste approach - having two identical profiles with different activation logic. At the same time, chaining profile activation is also prohibited. So, there are two possible things we can do:

1. Remove skip-validate-source from fast profile (using the profile would include resource validation step )
2. duplicate skip-validate-source profile with different activation logic e.g.

<activation>
  <property>
    <name>fast</name>
  </property>
</activation>

and change fast profile activation logic the same^ way

WDYT ?