Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Crane with felixfbecker PHP Language Server #2830

Merged
merged 1 commit into from
Oct 26, 2016

Conversation

kaloyan-raev
Copy link
Contributor

@kaloyan-raev kaloyan-raev commented Oct 19, 2016

What does this PR do?

Replaces HvyIndustries/crane with felixfbecker/php-language-server as the PHP language server.

felixfbecker/php-language-server is implemented in pure PHP, utilizes existing PHP Tools (like PHP Parser, CodeSniffer and phpDocumentor) and already attracts a few PHP developers to contribute.

The below attachment must be uploaded to https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.php.binaries
Attachment: php-language-server.tar.gz

The tarball includes the necessary PHP executable for running the PHP language server. No additional OS packages need to be installed.

What issues does this PR fix or reference?

Previous behavior

The Crane PHP language server used so far provided only limited code completion and no other capabilities. It was implemented in TypeScript, so it can't reuse existing PHP tools and has much less potential to attract the PHP community for contributions.

New behavior

In its current state the PHP language server comes with the following capabilities:

  • Code completion
  • Syntax validation
  • Document formatting
  • Document symbols
  • Workspace symbols
  • Go to definition
  • Find references
  • Hover support

Signed-off-by: Kaloyan Raev kaloyan.r@zend.com

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
@kaloyan-raev kaloyan-raev mentioned this pull request Oct 19, 2016
34 tasks
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@slemeur
Copy link
Contributor

slemeur commented Oct 19, 2016

Very cool !

@vparfonov vparfonov merged commit c0b6812 into eclipse-che:master Oct 26, 2016
@kaloyan-raev kaloyan-raev deleted the php-ls branch October 26, 2016 19:12
@kaloyan-raev
Copy link
Contributor Author

@vparfonov Thanks for merging the PR.

When do you plan to upload the attached binaries to https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.php.binaries?

The PHP language server in M7 builds cannot initialize properly until the binaries are uploaded. But if you upload the binaries then it will break the PHP language server initialization older milestones, because the old Crane language server won't be available at that location.

Should we upload the new PHP language server to a newer location?

@tolusha
Copy link
Contributor

tolusha commented Nov 2, 2016

@kaloyan-raev binaries updated

@kaloyan-raev
Copy link
Contributor Author

@tolusha Thank you!

@tolusha tolusha mentioned this pull request Nov 2, 2016
@bmicklea bmicklea added this to the 5.0.0 milestone Jan 11, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants