Replace Crane with felixfbecker PHP Language Server #2830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces HvyIndustries/crane with felixfbecker/php-language-server as the PHP language server.
felixfbecker/php-language-server is implemented in pure PHP, utilizes existing PHP Tools (like PHP Parser, CodeSniffer and phpDocumentor) and already attracts a few PHP developers to contribute.
The below attachment must be uploaded to https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.php.binaries
Attachment: php-language-server.tar.gz
The tarball includes the necessary PHP executable for running the PHP language server. No additional OS packages need to be installed.
What issues does this PR fix or reference?
Previous behavior
The Crane PHP language server used so far provided only limited code completion and no other capabilities. It was implemented in TypeScript, so it can't reuse existing PHP tools and has much less potential to attract the PHP community for contributions.
New behavior
In its current state the PHP language server comes with the following capabilities:
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com