Render hover messages according to LSP specification #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the hover message consists of multiple MarkedStrings then they should be joined via double newline, so they are rendered as seperate Markdown paragraphs. If a MarkedString has the `language` property provided then it should be rendered as a Markdown code block. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
kaloyan-raev
changed the title
|
Can one of the admins verify this patch? |
|
ci-build |
benoitf
added
kind/enhancement
|
Build # 759 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/759/ to view the results. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
If the hover message consists of multiple MarkedStrings then they should be joined via double newline, so they are rendered as seperate Markdown paragraphs. If a MarkedString has the `language` property provided then it should be rendered as a Markdown code block. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If the hover message consists of multiple
MarkedStrings then they should be joined via double newline, so they are rendered as separate Markdown paragraphs.If a
MarkedStringhas thelanguageproperty provided then it should be rendered as a Markdown code block.What issues does this PR fix or reference?
Previous behavior
New behavior
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com