Issue 2109 - DO NOT MERGE - 'test-lang' server #3123
Closed
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' server that can be used to test the upcoming pull requests related to the epic issue #2109. Issue #2109 To include the 'test-lang' server in the Che packaging: ``` git clone https://github.com/xcoulon/che-plugin-test-lang-server.git cd che-plugin-test-lang-server mvn clean install -Denforcer.skip=true -Dmdep.analyze.skip=true git clone https://github.com/xcoulon/test-language-server.git cd test-language-server mvn clean install ``` Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
|
Can one of the admins verify this patch? |
xcoulon
changed the title
vparfonov
pushed a commit
that referenced
this pull request
Dec 5, 2016
#3124) Added a ShowMessageProcessor and a ShowMessageMessager classes to process incoming `window/showMessage` notification and display a notification in `float` mode in the UI if the message type is `error` or `warning`, in the events panel otherwise. Note that the notification type for `error` messages is incorrectly set to `Log` because of a bug in the typefox dependency: `io.typefox.lsapi.MessageType#Log` has the value `1` instead of `4`. This issue depends on #3113 (Add a 'warning' state for the notifications) To test the pull request, please follow the instructions on #3123 to run the 'test-lang' server. Once in the workspace, create a project, add a `foo.test` file (the Language Server support for the 'test-lang' will be activated), then type the following line > window/showMessage:error: a message and wait for the editor to save the changes. This will trigger a `window/showMessage` notification from the 'test-lang' server in the Che UI. Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
|
@xcoulon - is this PR still needed for testing? |
|
@TylerJewell sorry for the late response. Yes, this PR includes the |
|
Can one of the admins verify this patch? |
|
Closing - was told by engineers this is no longer needed. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
eclipse-che#3124) Added a ShowMessageProcessor and a ShowMessageMessager classes to process incoming `window/showMessage` notification and display a notification in `float` mode in the UI if the message type is `error` or `warning`, in the events panel otherwise. Note that the notification type for `error` messages is incorrectly set to `Log` because of a bug in the typefox dependency: `io.typefox.lsapi.MessageType#Log` has the value `1` instead of `4`. This issue depends on eclipse-che#3113 (Add a 'warning' state for the notifications) To test the pull request, please follow the instructions on eclipse-che#3123 to run the 'test-lang' server. Once in the workspace, create a project, add a `foo.test` file (the Language Server support for the 'test-lang' will be activated), then type the following line > window/showMessage:error: a message and wait for the editor to save the changes. This will trigger a `window/showMessage` notification from the 'test-lang' server in the Che UI. Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please DO NOT merge this pull request!
What does this PR do?
This pull request's unique purpose is to add support for a 'test-lang' server that can be used to test the upcoming pull requests related to the epic issue #2109.
What issues does this PR fix or reference?
Issue #2109
Note
To include the 'test-lang' server in the Che packaging, run the following sets of commands:
Signed-off-by: Xavier Coulon xcoulon@redhat.com