Add "Run/Debug PHP script" commands to the PHP and Zend stacks #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
|
Can one of the admins verify this patch? |
vparfonov
approved these changes
Dec 5, 2016
tolusha
approved these changes
Dec 6, 2016
kaloyan-raev
added
the
kind/enhancement
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…se-che#3277) Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds commands to the PHP and Zend stacks for running and debugging PHP scripts, a.k.a. CLI apps:
QUERY_STRINGenv var, so a debug session is opened to the Zend Debugger engine.Both commands have a check if there is a file currently opened in the editor. If this is not the case, a user friendly message is printed.
What issues does this PR fix or reference?
This PR should be merge after merging the following two PRs:
Previous behavior
The user had to type these commands manually in the Terminal. While it is relatively easy for the "run php script" command, the
QUERY_STRINGenv var is complex and requires copying the value from some doc page.New behavior
Easier running and debugging of PHP scripts by executing Che commands.
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com