CHE-3369 Git history panel is not opened #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
reviewed
Dec 16, 2016
| } | ||
|
|
||
| TabItem tab = getTabByPart(part); | ||
| onTabClicked(tab); |
There was a problem hiding this comment.
tab is always non null ?
because signature of onTabClicked is requiring notNull but getTabByPart can return null
public void onTabClicked(@NotNull TabItem selectedTab) {
There was a problem hiding this comment.
if (containsPart(part)) {
TabItem tab = getTabByPart(part);
onTabClicked(tab);
return;
}
Yes, the case is confuses a little bit. But here tab must be not null because of there is a verification before.
benoitf
reviewed
Dec 16, 2016
| if (partStackJSON.hasKey("SIZE")) { | ||
| double size = partStackJSON.getNumber("SIZE"); | ||
|
|
||
| // Size of the part must not be less 100 pixels. |
There was a problem hiding this comment.
comment is for <100 but code is == 0 ?
There was a problem hiding this comment.
Thanks, fixed!
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1354/ |
ashumilova
approved these changes
Dec 19, 2016
vparfonov
approved these changes
Dec 19, 2016
|
Build # 1361 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1361/ to view the results. |
benoitf
pushed a commit
that referenced
this pull request
Dec 19, 2016
* CHE-3369 Git history panel is not opened * CHE-3369 Git history panel is not opened * CHE-3369 Git history panel is not opened
benoitf
pushed a commit
that referenced
this pull request
Dec 20, 2016
* CHE-3369 Git history panel is not opened * CHE-3369 Git history panel is not opened * CHE-3369 Git history panel is not opened
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* CHE-3369 Git history panel is not opened * CHE-3369 Git history panel is not opened * CHE-3369 Git history panel is not opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix appearing of the git history panel when the part is hidden.
Fix appearing of the git history panel after restoring the IDE state.
Fix the behavior of any hidden panel after restoring the IDE state.
#3369