Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3844: Show 'Add terminal button' in the machine node when WsAgent started. #4566

Closed
wants to merge 3 commits into from

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

Show 'Add terminal button' in the machine node when WsAgent started. Earlier We shown this button when machine had got status "running", but on this phase start IDE terminal agent was not installed yet.

What issues does this PR fix or reference?

#3844

Changelog

Show 'Add terminal button' in the machine node when WsAgent started.

Release Notes

Show 'Add terminal button' in the machine node when WsAgent started.

Docs PR

Not needed, this is bug fix.

started.

Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
@vparfonov
Copy link
Contributor

vparfonov commented Mar 28, 2017

But if machine status is "RUNNING" terminal agent should be ready, no?

@codenvy-ci
Copy link

Build # 2284 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2284/ to view the results.

@AndrienkoAleksandr
Copy link
Contributor Author

@vparfonov About "But if machine status is "RUNNING" terminal agent should be ready, no?" it really was in the some previous version, but not in the current version server api. Look here: https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceRuntimes.java#L430
We first start machine and during this operation machine gets status "creation" -> then "running", and after machine is running we launch agents.

@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Mar 29, 2017

I was wrong about this pull request. We should show terminal add button when workspace is running:
#4618

@AndrienkoAleksandr AndrienkoAleksandr deleted the CHE-3844-3 branch March 29, 2017 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants