CHE-5413 Remove unused agents related java code #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
gazarenkov,
tolusha,
garagatyi,
voievodin and
akorneta
garagatyi
added
the
target/branch
garagatyi
approved these changes
Jun 29, 2017
|
Thank you for splitting PR into purpose-based commits! |
gazarenkov
approved these changes
Jun 29, 2017
tolusha
approved these changes
Jun 29, 2017
|
Build # 2943 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2943/ to view the results. |
voievodin
approved these changes
Jun 29, 2017
akorneta
approved these changes
Jun 29, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2951/ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes agents launchers
Moves che-core-api-agent and che-core-api-agent to wsmaster module
Renames Agent entity to Installer (code changes only, for renaming in json files and database will be created issue)
Refactors Installer API
What issues does this PR fix or reference?
#5413
Note that changes separated in different commits and it's much easier to review commits one by one.