-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project service: Lazy init of Tika #6179
Conversation
Change-Id: I06872806f8a4c334614e1e15a12b5c533f5d8c11 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
4417bfe
to
29018d9
Compare
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3589/ |
Can we do some sort of provider or so? Or hide initialization logic inside some class instead of doing it in REST service? |
@skabashnyuk I fixed the issue, what you're asking is a refactoring on how ProjectService was designed ? AFAIK these changes are handled by maintainers not by contributors. |
@benoitf Can you elaborate on why the kind label is set to bug? |
@garagatyi you think it's an enhancement ? |
I do believe that marking everything as a bug is not convenient since it tempts ppl to mark everything as a bug to put up the priority and attention of other ppl in the project |
I've updated the label to enhancement if it's more convenient for people. |
thanks |
What does this PR do?
Lazy init of Tika.
Instead of initializing when constructor is called, initialize it at first call.
What issues does this PR fix or reference?
#6169
Changelog
lazily init the tika instance
Release Notes
N/A
Docs PR
N/A
Change-Id: I06872806f8a4c334614e1e15a12b5c533f5d8c11
Signed-off-by: Florent BENOIT fbenoit@redhat.com